Add option to use zlib-ng as zlib library #4487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Merge - To 1.14
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
lrknox
requested changes
May 15, 2024
Need to test but yes it should |
lrknox
approved these changes
May 24, 2024
tbeu
reviewed
May 26, 2024
| @@ -531,12 +531,18 @@ These five steps are described in detail below. | |||
| set (ZLIB_USE_LOCALCONTENT ON CACHE BOOL "Use local file for ZLIB FetchContent" FORCE) | |||
There was a problem hiding this comment.
Why is zlib not updated to v1.3.1 on the fly?
There was a problem hiding this comment.
We want to use the latest release after testing.
There was a problem hiding this comment.
OK. Why was libaec updated in this PR? Seems unrelated to zlib-ng.
There was a problem hiding this comment.
Because I have a bad habit of adding something I think is related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework compression libs CMake handling
Update to latest libaec version