Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v10.0.0: videoSrc and videoCaptions API updates, bug fixes, build system updates #88

Merged
merged 13 commits into from Mar 16, 2023
Merged

v10.0.0: videoSrc and videoCaptions API updates, bug fixes, build system updates #88

merged 13 commits into from Mar 16, 2023

Conversation

Gyanreyer
Copy link
Owner

Version 10 is ready! This includes some exciting changes:

Component changes

  • Deprecates passing config objects to videoSrc and videoCaptions props
    • This will bring some notable performance improvements and reduce the bundle size!
  • Removes shouldSuppressPlaybackInterruptedErrors prop
  • Fixes bugs/improves stability of how we track loading/playing states

Infrastructure changes

  • Completely rewrites all unit tests with Playwright instead of Cypress
    • Tests are way more stable, easier to write, and run significantly faster now!
  • Replaces rollup with esbuild
  • Drops CircleCI in favor of Github Workflows
  • Drops Semantic Release and commit message restrictions; this was just adding a ton of overhead that made it harder to contribute, and automated releases were not adding a huge amount of value. Going forward, I will just manually publish releases as needed

@Gyanreyer
feat: update videoSrc and videoCaptions API
4b2d35c 
Updates videoSrc and videoCaptions props to accept <source>/<track> elements instead of arrays of
config objects. Also makes various improvements to the component's implementation which should help
it work more consistently.

BREAKING CHANGE: videoSrc prop only accepts an src URL string or a set of <source> elements instead
of arrays of config objects now, and videoCaptions prop only accepts <track> elements instead of
arrays of config objects
@Gyanreyer
fix: bug fixes and code cleanup
8433028
@Gyanreyer
build: switch from rollup to esbuild, from cypress to playwright
43d21c3
@Gyanreyer
fix: clean up overlay style implementation, make isLoading events mor…
7af699e 
…e robust
@Gyanreyer
build: resolve npm audit warnings
c7cb45d
@Gyanreyer Gyanreyer force-pushed the feat/src-and-captions-api-improvements branch from 50c5841 to 2bee94d Compare March 13, 2023 22:21
@Gyanreyer Gyanreyer force-pushed the feat/src-and-captions-api-improvements branch from 2bee94d to 446143d Compare March 14, 2023 14:13
@Gyanreyer Gyanreyer merged commit 8f076f3 into main Mar 16, 2023
@Gyanreyer Gyanreyer deleted the feat/src-and-captions-api-improvements branch March 16, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Gyanreyer