New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage CI #194
Merged
Merged
Fix coverage CI #194
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d01788f
Merge pull request #1 from fennecdjay/master
TotallyNotChase e5128b7
:wrench: Use checkout + make instead of gwion-action for coverage
TotallyNotChase 1407fcb
:wrench: Fix branchname resolution during report generation
TotallyNotChase 374628f
:wrench: Make "Send mail" only execute in original repo
TotallyNotChase a3e0ecc
:wrench: Remove "Send mail" step from coverage report
TotallyNotChase d8e33cd
:wrench: Remove gwion-action from linux/macos/windows workflows
TotallyNotChase ca71c60
Merge branch 'ci-fixes' of https://github.com/TotallyNotChase/Gwion i…
TotallyNotChase 90173f4
:wrench: Remove comments from the end of file
TotallyNotChase 0530873
:wrench: Fix missing colon after name
TotallyNotChase 5bcd603
:wrench: Set cc back to gcc for windows
TotallyNotChase 6f9c888
:wrench: Make linux/macos/windows.yml actions run on PRs as well
TotallyNotChase 425ece7
:wrench: Set `BUILD_ON_WINDOWS` in windows.yml
TotallyNotChase c84b193
:wrench: Set `BUILD_ON_WINDOWS` on the test step as well
TotallyNotChase 7803344
:wrench: Separate steps for building and testing in coverage
TotallyNotChase File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,12 +18,14 @@ jobs: | |
if: "!contains(github.event.head_commit.message, '[skip ci]')" | ||
|
||
steps: | ||
- name: Build Gwion | ||
uses: fennecdjay/gwion-action@v1 | ||
with: | ||
dir: . | ||
ref: ${{ github.sha }} | ||
run: 'true' | ||
- name: Checkout | ||
uses: actions/checkout@v2 | ||
|
||
- name: Init submodules | ||
run: git submodule update --init util ast | ||
Comment on lines
+24
to
+25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Submodules on their own place is nice. |
||
|
||
- name: Build & Test Gwion | ||
run: make && make test | ||
TotallyNotChase marked this conversation as resolved.
Show resolved
Hide resolved
|
||
env: | ||
USE_COVERAGE: 1 | ||
|
||
|
@@ -51,7 +53,13 @@ jobs: | |
COV_NUM=${COV_TXT: : -1} | ||
echo $COV_NUM > gwion-coverage-report/coverage_num.txt | ||
sed -i 's/<html>/<script type="text\/javascript" src="..\/focus.js"><\/script><html>/' index.src_*.html | ||
branch=$(basename ${{ github.event.ref }}) | ||
if [ "${{ github.event_name }}" == "push" ] | ||
then | ||
ref="${{ github.ref }}" | ||
else | ||
ref="${{ github.event.head.ref }}" | ||
fi | ||
branch=$(basename ref) | ||
Comment on lines
+59
to
+65
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pretty useful snippet here. |
||
cd gwion-coverage-report/ | ||
bash old.sh $branch | ||
bash summary.sh | ||
|
@@ -95,17 +103,3 @@ jobs: | |
# git add -f html | ||
# git commit -m "Update html report" | ||
# git subtree push --prefix html origin gh-pages | ||
|
||
|
||
- name: Send mail | ||
uses: dawidd6/action-send-mail@master | ||
with: | ||
server_address: smtp.gmail.com | ||
server_port: 465 | ||
username: ${{ secrets.MAIL_USERNAME }} | ||
password: ${{ secrets.MAIL_PASSWORD }} | ||
subject: Github Actions job result | ||
body: file://diff.html | ||
to: ${{ github.event.repository.owner.email }},${{ github.event.pusher.email }} | ||
from: Gwion Coverage action | ||
content_type: text/html | ||
TotallyNotChase marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the thing asked for in the issue, you uncovered so many things beyond that!
Thank you.