Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate sci-m to builtins as sci-embodied #696

Merged
merged 13 commits into from
May 21, 2024
Merged

Migrate sci-m to builtins as sci-embodied #696

merged 13 commits into from
May 21, 2024

Conversation

jmcook1186
Copy link
Contributor

@jmcook1186 jmcook1186 commented May 3, 2024 •
edited

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

Migrates sci-m from if-plugins to builtins and rename to sci-embodied.
Addresses #683

@jmcook1186 jmcook1186 self-assigned this May 3, 2024
@jmcook1186 jmcook1186 added feature Some functionality to be developed size: medium medium sized task awaiting-dev-review PR is awaiting review from core dev epic: QA task inside the QA epic labels May 3, 2024
@jmcook1186 jmcook1186 linked an issue May 3, 2024 that may be closed by this pull request
Move sci-m to if/builtins with a name sci-embodied #683
Closed
6 tasks
manushak
manushak reviewed May 15, 2024
View reviewed changes
src/builtins/sci-embodied/README.md Outdated Show resolved Hide resolved
src/builtins/sci-embodied/README.md Outdated Show resolved Hide resolved
src/builtins/sci-embodied/README.md Show resolved Hide resolved
@jmcook1186
Apply suggestions from code review
d0c2c69 
Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
@jmcook1186 jmcook1186 added qa and removed awaiting-dev-review PR is awaiting review from core dev labels May 15, 2024
@jmcook1186 jmcook1186 mentioned this pull request May 16, 2024
Open
@jmcook1186
Apply suggestions from code review
6ea328e 
Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
@jmcook1186
Merge branch 'main' into migrate-plugins-to-builtins
592ae44 
Signed-off-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
@jmcook1186 jmcook1186 merged commit 2527dc3 into main May 21, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the migrate-plugins-to-builtins branch May 21, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manushak manushak manushak approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

@MariamKhalatova MariamKhalatova Awaiting requested review from MariamKhalatova

Assignees

@jmcook1186 jmcook1186

Labels
epic: QA task inside the QA epic feature Some functionality to be developed qa size: medium medium sized task
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move sci-m to if/builtins with a name sci-embodied
3 participants
@jmcook1186 @manushak @narekhovhannisyan