Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sci-m to if/builtins with a name sci-embodied #683

Closed
6 tasks done
Tracked by #656
zanete opened this issue Apr 29, 2024 · 1 comment · Fixed by #696
Closed
6 tasks done
Tracked by #656

Move sci-m to if/builtins with a name sci-embodied #683

zanete opened this issue Apr 29, 2024 · 1 comment · Fixed by #696
Assignees
Labels
epic: QA task inside the QA epic

Comments

@zanete
Copy link

zanete commented Apr 29, 2024

Sub of: #656

What
Move the sci-m plugin from if-plugins to if/builtins and rename it sci-embodied.

Why
This is part of our migration of our core plugins into a standard library in if/builtins.

Context
sci-m is not a very descriptive name - it is better to be more explicit about it - sci-embodied is more clearly the embodied carbon component of the SCI standard. This is a core feature we want to support, so it is migrating into if.

Prerequisites/resources
no

SoW (scope of work)

  • move plugin code into builtins/sci-embodied
  • fix any integration issues caused by the migration
  • migrate and fix unit tests
  • update README documentation updated

Acceptance criteria

  • plugin code is migrated to if-builtins
    Given (Setup): The migration has been completed.
    When (Action): A user or developer navigates to if
    Then (Assertion): they will find a folder if/builtins/sci-embodied containing the plugin source code and a README.

  • plugin code and unit tests pass and maintain 100% coverage
    Given (Setup): The migration has been completed and a user has downloaded if.
    When (Action): they run npx jest --coverage
    Then (Assertion): they will receive a report showing 100% coverage and 100% passing

@zanete zanete added the epic: QA task inside the QA epic label Apr 29, 2024
@zanete zanete added this to the Plugin Registry milestone Apr 29, 2024
@jmcook1186 jmcook1186 linked a pull request May 3, 2024 that will close this issue
9 tasks
@zanete
Copy link
Author

zanete commented May 20, 2024

@narekhovhannisyan please review 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic: QA task inside the QA epic
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants