Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random channel names #131

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Random channel names #131

wants to merge 5 commits into from

Conversation

dracco1993
Copy link
Member

Just throwing up a PR to make things easier to look at/review.

@@ -1,5 +1,546 @@
# frozen_string_literal: true

adjective_list = [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File temp_voice_event_container.rb has 597 lines of code (exceeds 250 allowed). Consider refactoring.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lolololol 😂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ummm y codeclimate forget this complaint for later on???

@dracco1993
Copy link
Member Author

One thing I was thinking about for this, it might be nice to have a setting that turns on/off the random names, versus the use of the user's name, just because in different instances, either would be helpful.

AdamKogut and others added 4 commits September 22, 2020 23:37
Co-authored-by: Jordan Miller <dracco1993@gmail.com>
Co-authored-by: Jordan Miller <dracco1993@gmail.com>
Co-authored-by: Jordan Miller <dracco1993@gmail.com>
@codeclimate
Copy link

codeclimate bot commented Sep 23, 2020

Code Climate has analyzed commit e76c5df and detected 0 issues on this pull request.

View more on Code Climate.

@dracco1993 dracco1993 self-assigned this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants