Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerability of moment.js #4640

Merged
merged 1 commit into from Mar 8, 2018
Merged

Fix vulnerability of moment.js #4640

merged 1 commit into from Mar 8, 2018

Conversation

kmerz
Copy link
Member

@kmerz kmerz commented Mar 7, 2018

Description

This change updates moment.js to a fixed version.

Motivation and Context

The javascript package moment.js had a vulnerability regarding
regular expresions.

moment/moment#4163
https://github.com/moment/moment/blob/2.21.0/CHANGELOG.md

How Has This Been Tested?

After the package was installed I've gone to the overview page and looked for errors
or warnings in the webconsole.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The javascript package moment.js had a vulnerability regarding
regular expresions.

moment/moment#4163
https://github.com/moment/moment/blob/2.21.0/CHANGELOG.md

This change updates moment.js to a fixed version.
@kmerz kmerz self-assigned this Mar 8, 2018
@kmerz kmerz added this to the 3.0.0 milestone Mar 8, 2018
@bernd bernd assigned bernd and unassigned kmerz Mar 8, 2018
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bernd bernd merged commit 458f3ec into master Mar 8, 2018
@bernd bernd deleted the moment-js-issue branch March 8, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants