Add modal to select index template on index creation #19381
+818
−216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousmaneo
requested changes
Jun 6, 2024
|
|
||
| type Props = { | ||
| showSelectTemplateModal: boolean, | ||
| setShowSelectTemplateModal: (boolean) => void |
There was a problem hiding this comment.
Can we name the function parameter here?
| @@ -15,16 +15,36 @@ | |||
| * <http://www.mongodb.com/licensing/server-side-public-license>. | |||
| */ | |||
|
|
|||
| import * as React from 'react'; | |||
| import React, { useMemo } from 'react'; | |||
There was a problem hiding this comment.
Suggested change
| import React, { useMemo } from 'react'; | |
| import * as React from 'react'; | |
| import { useMemo } from 'react'; |
| * along with this program. If not, see | ||
| * <http://www.mongodb.com/licensing/server-side-public-license>. | ||
| */ | ||
| import React, { useEffect } from 'react'; |
There was a problem hiding this comment.
Suggested change
| import React, { useEffect } from 'react'; | |
| import * as React from 'react'; | |
| import { useEffect } from 'react'; |
| @@ -102,7 +102,7 @@ const StyledTooltip = styled(Tooltip)(({ value }) => css` | |||
| position: absolute; | |||
| top: 0; | |||
|
|
|||
| ${value > 12 | |||
| ${value > 20 | |||
There was a problem hiding this comment.
We should move this value to a constant since we reuse it in many places.
| pageSize: 3, | ||
| query: 'built_in:true', | ||
| sort: sort, | ||
| }, { enabled: true }, |
There was a problem hiding this comment.
We can add the default value enabled = true to useTemplates, so we add the param only when we want to disable it.
| @@ -74,66 +83,98 @@ const formatRefreshInterval = (intervalInMs : number) => { | |||
|
|
|||
There was a problem hiding this comment.
We should add an Edit button to the template details page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/jpd Graylog2/graylog-plugin-enterprise#7363
This PR implements a modal to select an index set template on index set creation.
Besides that the PR also changes the following which should be tested as well:
Replace
defaultCheckedwithcheckedin<FormikInput>With the templates updating the form we need controlled Checkboxes, thus we need to use
checkedinstead ofdefaultCheckedPreselecting the first repository in warm tier repository select
Motivation and Context
Part of: #19075
How Has This Been Tested?
Please make sure to test in the following environments:
You can create built_in templates by creating a normal template on
/system/indices/templates/createand simply changingbuilt_intotruein theindex_set_templatestable in your mongodbScreenshots (if appropriate):
Based on the mockup in #index-templates Slack channel and discussions with @tellistone
Types of changes
Checklist: