Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct unit for byte fields. #19363

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

dennisoelkers
Copy link
Member

Description

Motivation and Context

This PR is fixing the unit (B) introduced in #19138 for byte fields, it should actually be b.

/nocl As changed feature was not shipped yet.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@janheise janheise merged commit 43038f7 into master May 16, 2024
5 checks passed
@janheise janheise deleted the fix/use-correct-unit-for-bytes branch May 16, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants