Display Data Node Logs #19352
Merged
Display Data Node Logs #19352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moesterheld
approved these changes
May 17, 2024
ousmaneo
requested changes
May 17, 2024
| <Button active={logsType === 'stderr'} onClick={() => setLogsType('stderr')}>STDERR</Button> | ||
| </ButtonGroup> | ||
| <pre> | ||
| {logs[logsType] ? ( |
There was a problem hiding this comment.
I think we should extract this section to DataNodeLogsView and use the hook in there so that the Actions component is cleaner.
| <Modal.Title>{dataNode.hostname} logs</Modal.Title> | ||
| </Modal.Header> | ||
| <Modal.Body> | ||
| <ButtonGroup> |
There was a problem hiding this comment.
We should also use the SegmentedControl here.
ousmaneo
pushed a commit
that referenced
this pull request
May 24, 2024
* DataNodeLogs initial setup * changelog file * Allow proxy access to datanode logs by default * Fix repsonse content type of not allowed proxy requests * show data node logs * close logs dialog on backdrop click * get the logs until one clicks "Show logs" * added review changes --------- Co-authored-by: Tomas Dvorak <tomas.dvorak@graylog.com>
ousmaneo
pushed a commit
that referenced
this pull request
May 29, 2024
* DataNodeLogs initial setup * changelog file * Allow proxy access to datanode logs by default * Fix repsonse content type of not allowed proxy requests * show data node logs * close logs dialog on backdrop click * get the logs until one clicks "Show logs" * added review changes --------- Co-authored-by: Tomas Dvorak <tomas.dvorak@graylog.com>
ousmaneo
pushed a commit
that referenced
this pull request
Jun 4, 2024
* DataNodeLogs initial setup * changelog file * Allow proxy access to datanode logs by default * Fix repsonse content type of not allowed proxy requests * show data node logs * close logs dialog on backdrop click * get the logs until one clicks "Show logs" * added review changes --------- Co-authored-by: Tomas Dvorak <tomas.dvorak@graylog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
fixes #17730
Types of changes
Checklist: