-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Units stored in search type metrics #19307
Merged
dennisoelkers
merged 3 commits into
master
from
units/units_stored_in_search_type_metrics
May 17, 2024
Merged
Units stored in search type metrics #19307
dennisoelkers
merged 3 commits into
master
from
units/units_stored_in_search_type_metrics
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luk-kaminski
changed the title
Units/units stored in search type metrics
Units stored in search type metrics
May 9, 2024
dennisoelkers
requested changes
May 10, 2024
...og2-server/src/main/java/org/graylog/plugins/views/search/searchtypes/pivot/MayHaveUnit.java
Outdated
Show resolved
Hide resolved
luk-kaminski
force-pushed
the
units/units_stored_in_search_type_metrics
branch
from
May 10, 2024 09:19
8d993a2
to
0508db0
Compare
dennisoelkers
force-pushed
the
units/units_stored_in_search_type_metrics
branch
from
May 17, 2024 07:12
0f14757
to
23115da
Compare
dennisoelkers
approved these changes
May 17, 2024
janheise
approved these changes
May 17, 2024
ousmaneo
pushed a commit
that referenced
this pull request
May 24, 2024
* Unit can be stored in chosen search types / metrics * Use Optional instead of Nullable * Not using optional in builder method. --------- Co-authored-by: Dennis Oelkers <dennis@graylog.com>
9 tasks
ousmaneo
pushed a commit
that referenced
this pull request
May 29, 2024
* Unit can be stored in chosen search types / metrics * Use Optional instead of Nullable * Not using optional in builder method. --------- Co-authored-by: Dennis Oelkers <dennis@graylog.com>
ousmaneo
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Unit can be stored in chosen search types / metrics * Use Optional instead of Nullable * Not using optional in builder method. --------- Co-authored-by: Dennis Oelkers <dennis@graylog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change is present in 0508db0 commit, put on top of not-yet-merged PR #19138
Selected metrics can now reference units.
Fixes #19308
/nocl
Motivation and Context
Needed by FE.
How Has This Been Tested?
Manually.
Types of changes
Checklist: