Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xml support added in aggregation widget export #19197

Merged
merged 2 commits into from Apr 30, 2024
Merged

Xml support added in aggregation widget export #19197

merged 2 commits into from Apr 30, 2024

Conversation

luk-kaminski
Copy link
Contributor

@luk-kaminski luk-kaminski commented Apr 29, 2024 •
edited

Description

Xml support added in aggregation widget export.
/nocl

Motivation and Context

XML export required by https://graylogdocumentation.atlassian.net/browse/GP-38

How Has This Been Tested?

Manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@luk-kaminski luk-kaminski changed the title Xml export support Xml support added in aggregation widget export Apr 29, 2024
@luk-kaminski luk-kaminski marked this pull request as ready for review April 29, 2024 12:22
@luk-kaminski luk-kaminski marked this pull request as draft April 29, 2024 12:57
@luk-kaminski luk-kaminski marked this pull request as ready for review April 30, 2024 06:42
janheise
janheise approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@janheise janheise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@janheise janheise merged commit 8541fcb into master Apr 30, 2024
7 checks passed
@janheise janheise deleted the exporting/xml branch April 30, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janheise janheise janheise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luk-kaminski @janheise