Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing "unknown format" error on sidecar overview page 6.0. #19129

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

linuspahl
Copy link
Contributor

@linuspahl linuspahl commented Apr 22, 2024

Please note, this is a backport of #19128 for 6.0.

Description

Motivation and Context

This PR is fixing an error which has been introduced with #18558 when renaming theme variables. It occurred when the overview contains inactive sidecars.

@linuspahl linuspahl requested a review from mpfz0r April 22, 2024 16:11
@ousmaneo ousmaneo self-requested a review April 22, 2024 16:16
@ousmaneo ousmaneo marked this pull request as ready for review April 22, 2024 16:45
Copy link
Contributor

@ousmaneo ousmaneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

@ousmaneo ousmaneo merged commit 0218130 into 6.0 Apr 23, 2024
6 checks passed
@ousmaneo ousmaneo deleted the issue-19012-6.0 branch April 23, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants