Cloud compatibility annotation #19054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickmann
requested review from
kodjo-anipah
and removed request for
kodjo-anipah
kodjo-anipah
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Install still ignoring error incompatible inputs
2024-04-15 11:57:33,506 WARN : org.graylog2.contentpacks.ContentPackService - Ignoring incompatible input org.graylog2.inputs.syslog.udp.SyslogUDPInput in cloud
creating inputs is possible again:
All inputs that a cloud compatible have the new annotation
patrickmann
added a commit
that referenced
this pull request
Apr 15, 2024
* refactor static cloud compatibility check * cloud compat annotation (cherry picked from commit fd427cd)
kodjo-anipah
pushed a commit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/nocl (bug in unreleased change)
/prd Graylog2/graylog-plugin-enterprise#7054
Relates to Graylog2/graylog-plugin-enterprise#7019
#18769 changed the signature of
MessageInput.Descriptormethods to be static, to support pre-install compatibility checks for content packs. However, other parts of the code rely on dynamic overriding of these methods.Instead we introduce a class annotation
@CloudCompatibleto indicate that an input class is compatible with Cloud.How Has This Been Tested?
Note: an exception is thrown when uninstalling a content pack. It is related to audit logging and is not relevant to this issue, since it reproduces on
master. We should fix that separately (#19034).Types of changes
Checklist: