Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable indexset templates #18956

Open
wants to merge 100 commits into
base: master
Choose a base branch
from
Open

Configurable indexset templates #18956

wants to merge 100 commits into from

Conversation

patrickmann
Copy link
Contributor

@patrickmann patrickmann commented Apr 9, 2024 •
edited by grotlue

Adds support for configurable indexset templates.

Part of #19075
/jpd Graylog2/graylog-plugin-enterprise#7055

Merge the related E2E tests PR after merging this one
https://github.com/Graylog2/e2e-tests/pull/818

Todos

  • add check that built in templates cannot be edited/deleted
  • Check: cannot delete the current default template (Anton)
  • Check: warm tier repositories cannot be delteted if used in index set template (Anton)
  • Fix audit events for /system/indices/index_set_defaults (Anton)
  • provide different built-in templates for cloud/on-premise
  • add built-in boolean fields to template DTO
  • add default boolean fields to template DTO (Anton)
  • Add index set template tab
  • Make sure that index set template tab is not visible on cloud
  • Make sure that index set template routes are not reachable on cloud
  • Add index set template list with
    • default label
    • Name, description and built_in column
    • Actions (not for built-in templates)
      • Edit
      • Set as default (if not default)
      • Delete (if not default)
  • Use new template defaults API for default values
  • Remove old Index Set defaults configuration code and section in System Configuration
  • Clean up index set form layout
  • Make Data Tiering components reusable
  • Clean up index set form layout
  • make Data Tiering components reusable
  • Add WarmTier Summary to Template Detail view

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

patrickmann and others added 22 commits April 9, 2024 18:11
@patrickmann
New collection index_set_templates
9bb664a
@patrickmann
CL
ed044b7
@patrickmann
read-only attribute
78f7866
@patrickmann
license header
6563c58
@patrickmann
register audit events
b213947
@patrickmann
register new resource
6d06c77
@patrickmann
add missing field
0c65c40
@patrickmann
remove redundant fields
eeffd35
@patrickmann
cleanup
08c4141
@patrickmann
template validation
8e704cd
@AntonEbel
migrate default config to template
6516512
@AntonEbel
add index template exists check before saving as default
e8d2fdd
@AntonEbel
Merge branch 'master' into indexsetTemplates
599fa8d
@AntonEbel
fix: add index template exists check before saving as default
bbabc6b
@patrickmann
indexset template provider
70bfb5b
@patrickmann
new migration to add/update built-in templates
5d15c2a
@AntonEbel
handle audit event for default index set template
c49e6fa
@AntonEbel
fix: add index default template audit event to list
b9238ae
@AntonEbel
rename index default template audit event
83cf8df
@AntonEbel
check that default template cannot be deleted
8189e8f
@grotlue
Add pages for IndexSetTemplates
cb78cbf
@AntonEbel
add default field
92a38fa
ousmaneo
ousmaneo requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@ousmaneo ousmaneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Here is the first round of testing and review. Looks good overall.

graylog2-web-interface/src/pages/IndexSetTemplatePage.tsx Outdated Show resolved Hide resolved
graylog2-web-interface/src/pages/IndexSetTemplatePage.tsx Outdated Show resolved Hide resolved
graylog2-web-interface/src/pages/IndexSetTemplatePage.tsx Outdated Show resolved Hide resolved
graylog2-web-interface/src/pages/IndexSetTemplatePage.tsx Outdated Show resolved Hide resolved
graylog2-web-interface/src/pages/IndexSetTemplateEditPage.tsx Outdated Show resolved Hide resolved
graylog2-web-interface/src/components/indices/IndexSetTemplates/TemplateActions.tsx Outdated Show resolved Hide resolved
graylog2-web-interface/src/components/indices/IndexSetTemplates/IndexSetTemplatesList.tsx Outdated Show resolved Hide resolved
graylog2-web-interface/src/components/indices/IndexSetTemplates/hooks/useTemplateMutation.ts Outdated Show resolved Hide resolved
graylog2-web-interface/src/components/indices/IndexSetTemplates/IndexSetTemplatesList.tsx Outdated Show resolved Hide resolved
graylog2-web-interface/src/components/indices/IndexSetTemplates/EditTemplate.tsx Outdated Show resolved Hide resolved
@grotlue grotlue requested a review from ousmaneo May 28, 2024 12:18
ousmaneo
ousmaneo requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@ousmaneo ousmaneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added one small comment.

graylog2-web-interface/src/components/indices/IndexSetTemplates/TemplateDetails.tsx
<FlexWrapper>
<Section title="Details">
<dl>
<dt>Index Analyzer:</dt>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for having a look, I think it would be great to have it aligned like below
image

I agree we should make this content consistent by updating the logic of the Summary component.

@grotlue grotlue requested a review from ousmaneo May 29, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grotlue grotlue grotlue left review comments

@AntonEbel AntonEbel AntonEbel left review comments

@ousmaneo ousmaneo ousmaneo approved these changes

@gally47 gally47 Awaiting requested review from gally47

Assignees

@grotlue grotlue

@patrickmann patrickmann

@AntonEbel AntonEbel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@patrickmann @grotlue @ousmaneo @AntonEbel