Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for GNOME Shell 46 #871

Open
1 task done
arm32x opened this issue Mar 26, 2024 · 3 comments
Open
1 task done

feat: Support for GNOME Shell 46 #871

arm32x opened this issue Mar 26, 2024 · 3 comments
Labels
enhancement New feature or request feature-request

Comments

@arm32x
Copy link

arm32x commented Mar 26, 2024

Feature description

The GNOME Shell theming support included in the nightly version of Gradience does not work with GNOME Shell 46. It would be nice if this was supported, especially considering that GNOME Shell 46 is now in the Arch package repos.

Additional Context

I'm using version 0.8.0.beta1.r199.gee5bc573-1 of the gradience-git package from the AUR. This is the stack trace that occurs when I press the Apply button:

Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/gradience/frontend/widgets/shell_theming_group.py", line 113, in on_apply_button_clicked
    user_themes_available = is_shell_ext_installed(ShellTheme().THEME_EXT_NAME)
                                                   ^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 59, in __init__
    self._detect_shell_version()
  File "/usr/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 278, in _detect_shell_version
    raise UnsupportedShellVersion(
gradience.backend.exceptions.UnsupportedShellVersion: GNOME Shell version 46 is not supported. (Supported versions: 42, 43, 44, 45)

Did you read the Code of Conduct?

@arm32x arm32x added enhancement New feature or request feature-request labels Mar 26, 2024
Copy link
Contributor

Welcome on Gradience. 🥳 We really appreciate your contribution. The core team will review your issue as soon as possible. You can also join the Matrix room: https://matrix.to/#/#Gradience-space:envs.net or the Discord server: https://discord.com/invite/4njFDtfGEZ

@nikelborm
Copy link

Doesn't work for me too, but with different error on gnome 46

(gradience:341594): Gtk-CRITICAL **: 19:18:26.276: Unable to retrieve child object 'settings-button' from class template for type 'GradiencePluginRow' while building a 'GradiencePluginRow'
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/gi/_gtktemplate.py", line 170, in <lambda>
    lambda s: init_template(s, cls, base_init_template)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/gi/_gtktemplate.py", line 193, in init_template
    raise RuntimeError(
RuntimeError: Handler 'on_settings_plugin_clicked' was declared with @Gtk.Template.Callback but was not present in template

(gradience:341594): Gtk-CRITICAL **: 19:18:26.277: Unable to retrieve child object 'settings-button' from class template for type 'GradiencePluginRow' while building a 'GradiencePluginRow'
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/gi/_gtktemplate.py", line 170, in <lambda>
    lambda s: init_template(s, cls, base_init_template)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/gi/_gtktemplate.py", line 193, in init_template
    raise RuntimeError(
RuntimeError: Handler 'on_settings_plugin_clicked' was declared with @Gtk.Template.Callback but was not present in template
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/gradience/frontend/main.py", line 117, in do_activate
    self.setup_plugins()
  File "/usr/lib/python3.11/site-packages/gradience/frontend/main.py", line 629, in setup_plugins
    self.plugins_group = self.plugins_list.to_group()
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/gradience/frontend/views/plugins_list.py", line 98, in to_group
    row = GradiencePluginRow(pluginInfo.plugin_object, preset, self)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/gradience/frontend/widgets/plugin_row.py", line 60, in __init__
    self.switch.set_active(True)
    ^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'set_active'

@drannex42
Copy link

Throwing my report in the ring here. Gnome 46. Running off Nightly.

Traceback (most recent call last):
  File "/app/lib/python3.11/site-packages/gradience/frontend/widgets/shell_theming_group.py", line 113, in on_apply_button_clicked
    user_themes_available = is_shell_ext_installed(ShellTheme().THEME_EXT_NAME)
                                                   ^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 59, in __init__
    self._detect_shell_version()
  File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 278, in _detect_shell_version
    raise UnsupportedShellVersion(
gradience.backend.exceptions.UnsupportedShellVersion: GNOME Shell version 46 is not supported. (Supported versions: 42, 43, 44, 45)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-request
Projects
Status: Todo
Development

No branches or pull requests

3 participants