⚠️ Shell Engine Roadmap (see for list of bugs) #763

tfuxu · 2023-05-04T10:11:04Z

V-Mann-Nick · 2023-05-08T17:19:23Z

Thank you very much for the awesome work. I'm already using the shell engine and it looks really great. I really only noticed one minor thing: the dropdown in the quick settings have default color.

Screenshot

tfuxu · 2023-05-08T19:29:41Z

Thank you for your kind words! The issue you described here is the first item in issues list, I'll try to fix it as soon as I have some free time this week.

V-Mann-Nick · 2023-05-09T12:09:39Z

Perfect. Appreciate it a lot. Sorry for my redundant comment.

0xMRTT · 2023-05-14T14:51:31Z

Shell doesn't support @var_name so a function for converting each @var_name to the hex/rgb value is needed since @ vars are LibAdwaita only

tfuxu · 2023-05-14T15:56:05Z

Shell doesn't support @var_name so a function for converting each @var_name to the hex/rgb value is needed since @ vars are LibAdwaita only

Fixed in 1a5b1f4. We already have a function to handle that, it was just buggy.

sidevesh · 2023-07-12T14:27:06Z

@tfuxu Can we add touch keyboard keys to this ? The keyboard background allready uses the theme colors, only the keys need to be adapted.

0xMRTT · 2023-07-12T17:29:29Z

@sidevesh yes it should be possible

https://gitlab.gnome.org/GNOME/gnome-shell-sass/-/blob/master/widgets/_keyboard.scss#L33

tfuxu · 2023-07-12T17:36:21Z

@tfuxu Can we add touch keyboard keys to this ? The keyboard background allready uses the theme colors, only the keys need to be adapted.

Sure, we can add it to the list

0xMRTT · 2023-07-12T17:37:54Z

got it, it's already possible :)

0xMRTT · 2023-07-12T17:40:04Z

$key_bg_color = darken($osd_fg_color, 70%); and osd_fg_color can be set here:

I agree that it looks a wrong but the idea is here :). It will require a bit more customization for having the background

0xMRTT · 2023-07-12T17:43:02Z

without any tweaks, just by using the Catpuccin Mocha preset I got :

⚠️ you need to use nightly for having the Shell theming feature

tfuxu · 2023-07-12T17:51:11Z

Great, first one off the list ☑️

0xMRTT · 2023-07-12T19:29:56Z

@tfuxu I'm going to fix them soon. (this one wasn't an issue ... It was just available but unused by @sidevesh)

sidevesh · 2023-07-13T04:25:09Z

@0xMRTT I don't see where I can add these options, I see osd_fg_color already there in that list but not key_bg_color, and I don't see how I can add it

0xMRTT · 2023-07-13T08:55:12Z

@sidevesh That's because there isn't key_bg_color osd_fg_color do the job. Have a look at the catpuccin Mocha theme!

sidevesh · 2023-08-01T12:42:46Z

Found another issue that started happening recently, the sidebar in Geary seems to not get its color updated anymore,
not sure if this happened due to updates to the app or adw-gtk3 theme (Geary is still using gtk3)

sidevesh · 2023-08-02T04:35:08Z

I couldn't test with newest commits since the arch aur gradience-git package is broken currently and does not build anymore

0xMRTT · 2023-08-15T19:48:31Z

QS Menu issue has been fixed!

sidevesh · 2023-08-16T22:34:59Z

Looks like gradience is completed borked now :(
I can regenerate the gtk.css from Material You shell extension but then applying from Gradience deletes it again.
No idea how this happened.

Reinachan · 2023-08-30T16:10:31Z

Some accent colours make the quick settings look a bit off.

Notice the dark line on the active pills with dropdowns. It ends up oversaturated and looks almost like it's too wide?

This is how the default colours are. As you can see, that line doesn't stick out as much here.

I'm using the 0.8.0-beta1 from flathub. Colours are:

Both backgrounds: #0d0d0d
All foregrounds: #ffffff
Accent: #ff8686

inthreedee · 2023-09-09T20:12:10Z

The sidebar color issue with Geary that was mentioned by @sidevesh above (#763 (comment)) appears to be an upstream adw-gtk3 v4.9 issue, as downgrading to adw-gtk3 v4.8 fixes it. I've reported it here: lassekongo83/adw-gtk3#240

0xMRTT · 2023-09-10T07:44:03Z

@inthreedee This issue is part of the new Libadwaita 1.4 widgets (sidebar and secondary sidebar). You can configure this vars with Gradience nightly

ParaSpl01t · 2023-12-11T06:28:14Z

Is shell theming available in GNOME 45.2 right now?
I'm using gradience-git 0.8.0.beta1.r96.gab70ed87-1 from aur
Everything works using pretty purple theme except shell gnome shell quick settings.

EDIT: I missed the APPLY button under Shell Engine option in theming tab. everything works now.

manan-gup · 2023-12-18T18:37:08Z

Hi, I've installed the 0.8.0-beta1-36b91fe flatpak nightly package. I tried applying the shell theme using the apply button in the shell engine section but nothing happened. Tried logging out too to no avail. Can I do anything to troubleshoot this?

daudix · 2023-12-18T19:30:37Z

@manan-gup do you have "User Themes" extension installed and enabled?

manan-gup · 2023-12-18T19:39:49Z

Yes I do. Should I disable it?

daudix · 2023-12-18T19:41:21Z

Nope. Could you check if there are theme with gradience in the name available? If there are one select it

manan-gup · 2023-12-18T19:44:03Z

This is what I'm getting. The Sweet* themes have been manually installed.

daudix · 2023-12-18T19:46:55Z

Hm, odd. Are you sure that you press the right apply button? (you need to press apply that are located in the shell theming section)

manan-gup · 2023-12-18T19:48:02Z

Yes, I pressed this one.

daudix · 2023-12-18T19:49:55Z

Alright, can you launch it from terminal with flatpak run com.github.GradienceTeam.Gradience.Devel and send the output here please

manan-gup · 2023-12-18T19:53:06Z

Traceback (most recent call last):
  File "/app/lib/python3.11/site-packages/gradience/frontend/widgets/shell_theming_group.py", line 113, in on_apply_button_clicked
    user_themes_available = is_shell_ext_installed(ShellTheme().THEME_EXT_NAME)
                                                   ^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 59, in __init__
    self._detect_shell_version()
  File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 326, in _detect_shell_version
    raise UnsupportedShellVersion(
gradience.backend.exceptions.UnsupportedShellVersion: GNOME Shell version 45 is not supported. (Supported versions: 42, 43, 44)

Oh, my bad. I didn't know that Gnome 45 is not supported.
It would be nice to get this message in the UI as well.

daudix · 2023-12-18T19:54:20Z

Hm, it should be, try this build: https://github.com/GradienceTeam/Gradience/actions/runs/7214048889/artifacts/1115721706

manan-gup · 2023-12-18T19:58:46Z

Hm, it should be, try this build: https://github.com/GradienceTeam/Gradience/actions/runs/7214048889/artifacts/1115721706

It worked with this build. Thanks!

daudix · 2023-12-18T20:08:03Z

You're welcome ^^

CaragC · 2024-01-07T15:01:13Z

Using this build, when clicking the apply button next to "Shell Theming Options", nothing happens. The console prints out the following when running flatpak run com.github.GradienceTeam.Gradience.Devel

[Gradience] DEBUG: Spawning: ['flatpak-spawn', '--host', 'gnome-shell', '--version']

** (gradience:2): WARNING **: 15:59:06.037: Failed to load shared library 'libportal.so.1' referenced by the typelib: /app/lib/libportal.so.1: undefined symbol: g_once_init_leave_pointer
/app/lib/python3.11/site-packages/gradience/backend/globals.py:98: Warning: cannot retrieve class for invalid (unclassed) type 'void'
  portal = Xdp.Portal()
Traceback (most recent call last):
  File "/app/lib/python3.11/site-packages/gradience/frontend/widgets/shell_theming_group.py", line 113, in on_apply_button_clicked
    user_themes_available = is_shell_ext_installed(ShellTheme().THEME_EXT_NAME)
                                                   ^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 75, in __init__
    settings_retriever = FlatpakGSettings if is_sandboxed() else GSettingsSetting
                                             ^^^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/gradience/backend/globals.py", line 98, in is_sandboxed
    portal = Xdp.Portal()
             ^^^^^^^^^^^^
TypeError: could not get a reference to type class

Is there anyway to fix this?

daudix · 2024-01-07T15:21:41Z

@CaragC do you have User Themes extension installed? it is needed for the shell theming to work

CaragC · 2024-01-07T17:30:01Z

Yes it is installed and does not show any Gradience themes. The second theme I installed myself.

daudix · 2024-01-07T17:31:37Z

Hm, that's weird, can you try the latest build? https://nightly.link/GradienceTeam/Gradience/workflows/build/main

CaragC · 2024-01-07T17:36:36Z

This still gives the same error as before, also the same error is given when clicking "Reset Theme"

[Gradience] DEBUG: Spawning: ['flatpak-spawn', '--host', 'gnome-shell', '--version']

** (gradience:2): WARNING **: 18:35:31.542: Failed to load shared library 'libportal.so.1' referenced by the typelib: /app/lib/libportal.so.1: undefined symbol: g_once_init_leave_pointer
/app/lib/python3.11/site-packages/gradience/backend/globals.py:98: Warning: cannot retrieve class for invalid (unclassed) type 'void'
  portal = Xdp.Portal()
Traceback (most recent call last):
  File "/app/lib/python3.11/site-packages/gradience/frontend/widgets/shell_theming_group.py", line 113, in on_apply_button_clicked
    user_themes_available = is_shell_ext_installed(ShellTheme().THEME_EXT_NAME)
                                                   ^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/gradience/backend/theming/shell.py", line 75, in __init__
    settings_retriever = FlatpakGSettings if is_sandboxed() else GSettingsSetting
                                             ^^^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/gradience/backend/globals.py", line 98, in is_sandboxed
    portal = Xdp.Portal()
             ^^^^^^^^^^^^
TypeError: could not get a reference to type class

manan-gup · 2024-01-08T02:43:23Z

Failed to load shared library 'libportal.so.1'

Do you have the xdg-desktop-portal and libportal packages installed?

CaragC · 2024-01-08T09:41:01Z

Both of the packages are installed

sidevesh · 2024-02-09T08:16:27Z

Another issue with Geary after fixing the earlier issue by adding the Adw 1.4 colors to the theme json,

this happens when window is not in foreground,
I can't figure out which backdrop or otherwise color maps to this #303030 color.

EDIT: Earlier this color was #FFF but after a log out and login after applying the theme it turned #303030.

sidevesh · 2024-02-26T00:49:02Z

Any idea about the above issue @daudix ?

daudix · 2024-02-26T00:50:59Z

I've no idea, the version from main has some issues with sidebar theming, you can try beta1 which appears to not have these

drannex42 · 2024-04-09T14:53:51Z

Gnome 46 support hasn't been added, adding this so others can find it: #871

tfuxu added enhancement New feature or request feature-request labels May 4, 2023

tfuxu modified the milestone: 0.8.0 May 4, 2023

tfuxu added the area/gnome-shell label May 4, 2023

0xMRTT mentioned this issue May 16, 2023

bug: Various shell elements colored improperly #768

Open

2 tasks

This was referenced Jul 5, 2023

feat: Allow to change Gnome Shell top panel color #798

Closed

bug: Theming issues with panels in gnome shell #801

Closed

daudix pinned this issue Jul 10, 2023

daudix changed the title ~~Shell Engine Roadmap~~ Shell Engine Roadmap (bugs are listed here) Jul 10, 2023

daudix changed the title ~~Shell Engine Roadmap (bugs are listed here)~~ ⚠️ Shell Engine Roadmap (see for list of bugs) Jul 10, 2023

sidevesh mentioned this issue Jul 13, 2023

Set window_fg_color, to fix keyboard keys color GradienceTeam/Community#99

Merged

0xMRTT closed this as completed Sep 10, 2023

0xMRTT reopened this Sep 10, 2023

⚠️ Shell Engine Roadmap (see for list of bugs) #763

⚠️ Shell Engine Roadmap (see for list of bugs) #763

Comments

tfuxu commented May 4, 2023 • edited by 0xMRTT

Feature description

Roadmap:

Issues:

Additional Context

Did you read the Code of Conduct?

V-Mann-Nick commented May 8, 2023 • edited

tfuxu commented May 8, 2023

V-Mann-Nick commented May 9, 2023

0xMRTT commented May 14, 2023

tfuxu commented May 14, 2023

sidevesh commented Jul 12, 2023

0xMRTT commented Jul 12, 2023 • edited

tfuxu commented Jul 12, 2023

0xMRTT commented Jul 12, 2023

0xMRTT commented Jul 12, 2023

0xMRTT commented Jul 12, 2023

tfuxu commented Jul 12, 2023

0xMRTT commented Jul 12, 2023 • edited

sidevesh commented Jul 13, 2023

0xMRTT commented Jul 13, 2023

sidevesh commented Aug 1, 2023

sidevesh commented Aug 2, 2023

0xMRTT commented Aug 15, 2023

sidevesh commented Aug 16, 2023

Reinachan commented Aug 30, 2023

inthreedee commented Sep 9, 2023

0xMRTT commented Sep 10, 2023

ParaSpl01t commented Dec 11, 2023 • edited

manan-gup commented Dec 18, 2023

daudix commented Dec 18, 2023

manan-gup commented Dec 18, 2023

daudix commented Dec 18, 2023

manan-gup commented Dec 18, 2023

daudix commented Dec 18, 2023 • edited

manan-gup commented Dec 18, 2023

daudix commented Dec 18, 2023 • edited

manan-gup commented Dec 18, 2023 • edited

daudix commented Dec 18, 2023

manan-gup commented Dec 18, 2023 • edited

daudix commented Dec 18, 2023

CaragC commented Jan 7, 2024

daudix commented Jan 7, 2024

CaragC commented Jan 7, 2024

daudix commented Jan 7, 2024

CaragC commented Jan 7, 2024 • edited

manan-gup commented Jan 8, 2024 • edited

CaragC commented Jan 8, 2024

sidevesh commented Feb 9, 2024 • edited

sidevesh commented Feb 26, 2024

daudix commented Feb 26, 2024

drannex42 commented Apr 9, 2024

tfuxu commented May 4, 2023 •

edited by 0xMRTT

V-Mann-Nick commented May 8, 2023 •

edited

0xMRTT commented Jul 12, 2023 •

edited

0xMRTT commented Jul 12, 2023 •

edited

ParaSpl01t commented Dec 11, 2023 •

edited

daudix commented Dec 18, 2023 •

edited

daudix commented Dec 18, 2023 •

edited

manan-gup commented Dec 18, 2023 •

edited

manan-gup commented Dec 18, 2023 •

edited

CaragC commented Jan 7, 2024 •

edited

manan-gup commented Jan 8, 2024 •

edited

sidevesh commented Feb 9, 2024 •

edited