Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Linux/Unix to README #43

Open
wants to merge 8 commits into
base: community
Choose a base branch
from
Open

Conversation

mrtuxa
Copy link

@mrtuxa mrtuxa commented Mar 22, 2023

I have made improvements to the README text section for macOS and created a new section for Linux/Unix. In the macOS section, I added information about the make -j parameter to speed up code compilation. In the Linux/Unix section, I provided instructions on how to set up and compile the source code.

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2023

CLA assistant check
All committers have signed the CLA.

@misery
Copy link
Contributor

misery commented Mar 22, 2023

Thanks. But -j is already used in the sub calls of openssl and Qt. Our libs script won't be faster if you provide -j like this.
See: https://github.com/Governikus/AusweisApp2/blob/community/libs/CMakeLists.txt#L65

@mrtuxa
Copy link
Author

mrtuxa commented Mar 22, 2023

I will improve

libs/README.rst Outdated Show resolved Hide resolved
libs/README.rst Outdated Show resolved Hide resolved
@mrtuxa
Copy link
Author

mrtuxa commented Mar 23, 2023

sollte jetzt alles passen

@mrtuxa
Copy link
Author

mrtuxa commented Mar 28, 2023

passt jetzt alles?

@mrtuxa mrtuxa requested review from misery and marceltransier and removed request for misery and marceltransier March 28, 2023 08:02
@mrtuxa mrtuxa requested a review from MrKinau April 18, 2023 11:07
libs/README.rst Outdated Show resolved Hide resolved
Co-authored-by: Tejas Kale <tejaskale27@gmail.com>
@mrtuxa mrtuxa requested a review from tejaskale August 27, 2023 11:12
Copy link

@GitMensch GitMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase that and do the minor adjustments?
This is an useful update so it would be good to get it in.

libs/README.rst Outdated Show resolved Hide resolved
::

$ cd /Users/governikus
$ cd /home/governikus

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make that $HOME and it is portable

@misery misery self-assigned this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants