fix: evaluate return_code from rctx.execute() call when fetching package indexes #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase? |
alexconrey
force-pushed
the
alexconrey/packages-decompress-eval-exitcode-success
branch
from
35a417d
to
bf57211
Compare
|
@thesayyn think this is ready for another glance. Sorry for the delay! |
alexconrey
force-pushed
the
alexconrey/packages-decompress-eval-exitcode-success
branch
from
bf57211
to
54fb5de
Compare
thesayyn
approved these changes
May 22, 2024
|
Thank you! |
alexconrey
deleted the
alexconrey/packages-decompress-eval-exitcode-success
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
rctx.execute()call when fetching package indexes does not evaluate the tool's return code. This allows for weirdness should an archive be uploaded to an HTTP server which was improperly compressed or contains otherwise invalid data.Solution
Evaluate the return code from the executing tools. Both tools return non-zero codes when an error is reached.