Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(testing pr) experimenting with changes to fix apiary client auth #400

Closed
wants to merge 4 commits into from

Conversation

dzou
Copy link
Contributor

@dzou dzou commented Mar 18, 2021

Still not sure if it is a change needed on our end or in the auth libraries.

Some discussion of this here: googleapis/google-auth-library-java#601 (review)

But maybe we need to make a change on our end.

@dzou dzou changed the title (test) Try rolling back libraries-bom (testing pr) experimenting with changes to fix apiary client auth Mar 18, 2021
@dzou dzou marked this pull request as draft March 18, 2021 21:35
@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2021

@dzou
Copy link
Contributor Author

dzou commented Mar 18, 2021

I printed out the auth scopes to verify that they were being attached to the credential: https://github.com/GoogleCloudPlatform/spring-cloud-gcp/runs/2143797505

I think we have it correct on our end at least. Curious to see if the new version will fix the problem for us.

@arithmetic1728
Copy link

I printed out the auth scopes to verify that they were being attached to the credential: https://github.com/GoogleCloudPlatform/spring-cloud-gcp/runs/2143797505

I think we have it correct on our end at least. Curious to see if the new version will fix the problem for us.

In auth lib v0.25.0 we ignored the scopes and it was corrected in the fix. Sorry for the trouble.

It should go back to normal after libraries-bom PR is merged or released: GoogleCloudPlatform/cloud-opensource-java#1992

@meltsufin
Copy link
Member

Just upgraded. So, closing this.

@meltsufin meltsufin closed this Mar 19, 2021
prash-mi pushed a commit that referenced this pull request Jun 20, 2023
Bumps [spring-boot-starter-parent](https://github.com/spring-projects/spring-boot) from 2.5.1 to 2.5.2.
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v2.5.1...v2.5.2)

---
updated-dependencies:
- dependency-name: org.springframework.boot:spring-boot-starter-parent
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants