Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanner float32 support #785

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Spanner float32 support #785

wants to merge 11 commits into from

Conversation

shubhamswe
Copy link

@shubhamswe shubhamswe commented Mar 11, 2024 •
edited

Fixes #<issue_number_goes_here>

[DO NOT REVIEW] This PR is work in progress.

  • Tests pass
  • Appropriate changes to README are included in PR

@shubhamswe shubhamswe requested a review from a team as a code owner March 11, 2024 12:44
@shubhamswe shubhamswe requested review from shreyakhajanchi and aksharauke and removed request for a team March 11, 2024 12:44
arawind
arawind reviewed Mar 15, 2024
View reviewed changes
sources/postgres/toddl_test.go Outdated Show resolved Hide resolved
sources/mysql/toddl_test.go Show resolved Hide resolved
sources/mysql/mysqldump_test.go Outdated Show resolved Hide resolved
@shubhamswe shubhamswe requested a review from arawind March 15, 2024 10:52
@manitgupta
Copy link
Member

@shreyakhajanchi Please review.

shreyakhajanchi
shreyakhajanchi reviewed Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is float32 being added to PG dialect as well ? If the syntax differs or if its not added then PG dialect handling for Float32 should also be added

sources/csv/data.go Show resolved Hide resolved
sources/csv/toddl.go Show resolved Hide resolved
sources/mysql/toddl.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aksharauke aksharauke Awaiting requested review from aksharauke aksharauke is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

@arawind arawind Awaiting requested review from arawind

@shreyakhajanchi shreyakhajanchi Awaiting requested review from shreyakhajanchi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shubhamswe @manitgupta @arawind @shreyakhajanchi