feat(functions/slack): add GCF v2 decorators #7889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: cloudfunctions
dandhlee
requested changes
May 13, 2022
| @@ -89,6 +90,7 @@ def make_search_request(query): | |||
|
|
|||
|
|
|||
| # [START functions_slack_search] | |||
| @functions_framework.http | |||
There was a problem hiding this comment.
Sorry I'm not too informed about this decorator, is this for good practice? If this is a recommended approach, and this is going to show up on the Sample Browser as well, I think it might be good to be able to point users towards some sort of documentation that explains why using this might be beneficial!
There was a problem hiding this comment.
I don't think it was documented; This PR GoogleCloudPlatform/functions-framework-nodejs#347 is the most detailed bit I could find. Thoughts on whether we should point to it?
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
iennae
approved these changes
May 13, 2022
leahecole
pushed a commit
that referenced
this pull request
May 25, 2022
* feat(functions/slack): add GCF v2 decorators * Fix lint * Fix copyright * Bots hate commas * Humans hate commas too * Fix copyright Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com> Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ I've confirmed this works on GCF itself.