Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bigtable samples #3906

Merged
merged 2 commits into from Jul 24, 2020
Merged

Remove Bigtable samples #3906

merged 2 commits into from Jul 24, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented May 29, 2020

Do not merge until googleapis/python-bigtable#38 and internal PR 314369865 are merged

@busunkim96 busunkim96 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 29, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2020
@busunkim96 busunkim96 force-pushed the delete-bigtable branch 2 times, most recently from d4eb02e to d7fe69d Compare July 15, 2020 21:47
@busunkim96 busunkim96 marked this pull request as ready for review July 15, 2020 21:48
@busunkim96 busunkim96 requested a review from a team as a code owner July 15, 2020 21:48
@busunkim96 busunkim96 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 17, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Jul 20, 2020

@busunkim96 Can you rebase to the master and resolve conflict?

@busunkim96 busunkim96 merged commit 9e8020f into master Jul 24, 2020
@busunkim96 busunkim96 deleted the delete-bigtable branch July 24, 2020 00:32
@odedfos
Copy link
Contributor

odedfos commented Aug 19, 2020

@busunkim96 , why were all the bigtable samples removed?

@busunkim96
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants