feat: Onboard Chicago Crime dataset #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlersantos
requested changes
Sep 16, 2021
datasets/chicago_crime/_images/run_csv_transform_kub/csv_transform.py
Outdated
Show resolved
Hide resolved
datasets/chicago_crime/_images/run_csv_transform_kub/csv_transform.py
Outdated
Show resolved
Hide resolved
datasets/chicago_crime/_images/run_csv_transform_kub/requirements.txt
Outdated
Show resolved
Hide resolved
adlersantos
requested changes
Sep 28, 2021
Comment on lines
+88
to
+99
|
|
||
|
|
||
| bucket: "{{ var.json.shared.composer_bucket }}" | ||
|
|
||
|
|
||
| source_objects: ["data/chicago_crime/crime/data_output.csv"] | ||
| source_format: "CSV" | ||
| destination_project_dataset_table: "chicago_crime.crime" | ||
|
|
||
|
|
||
| skip_leading_rows: 1 | ||
|
|
There was a problem hiding this comment.
Nit: After removing comments, please also remove the extra whitespaces.
| # limitations under the License. | ||
|
|
||
| # The base image for this build | ||
| # FROM gcr.io/google.com/cloudsdktool/cloud-sdk:slim |
4 tasks
|
@adlersantos - closing this one as this branch is facing some issues . I have created a new PR #199 for the same dataset. |
|
Closing due to new PR version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #
Note: It's recommended to open an issue first for context and discussion.
Checklist
Note: Delete items below that aren't applicable to your pull request.
datasets/chicago_crimeand nothing outside of that directory.