fix: reduce request usage #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
grant
approved these changes
Feb 18, 2020
ace-n
approved these changes
Feb 19, 2020
| @@ -15,7 +15,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| // [START functions_background_promise] | |||
| const requestPromiseNative = require('request-promise-native'); | |||
| const {request} = require('gaxios'); | |||
There was a problem hiding this comment.
Nit: does the leading G in gaxios stand for Google here?
(If so, perhaps it should be moved to the GoogleCloudPlatform org instead of a personal repo.)
There was a problem hiding this comment.
This is a Google owned module :) It lives in the googleapis org:
https://github.com/googleapis/gaxios/
There was a problem hiding this comment.
Ah - I was going off of the npm entry. Maybe we should update that? 🙂
There was a problem hiding this comment.
Good catch! googleapis/gaxios#239
fhinkel
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request is now deprecated. This moves the sample over to using
gaxios, along with other cleanup.