Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add image proxy to frontend server #1717

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Add image proxy to frontend server #1717

wants to merge 2 commits into from

Conversation

arbrown
Copy link
Contributor

@arbrown arbrown commented Apr 20, 2023 •
edited by NimJay

Background

Summary of change

  • Currently this is set up to forward traffic to a public GCS (Google Cloud Storage) bucket as a proof-of-concept for properly decoupling the frontend and the productcatalogservice.

@arbrown
feat: Add image proxy to frontend server
683a1b3 
Currently this is set up to forward traffic to a public GCS bucket as a proof of concept for properly decoupling the frontend and the productcatalogservice.

Do not submit as is. Needs some more polishing.
@github-actions
Copy link

🚲 PR staged at http://34.170.32.60

@github-actions
Copy link

🚲 PR staged at http://34.170.32.60

@NimJay NimJay added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 18, 2023
@NimJay NimJay added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 15, 2023
shakeebshams

This comment was marked as outdated.

Sign in to view

@NimJay NimJay added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakeebshams shakeebshams shakeebshams approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver will be requested when the pull request is marked ready for review yoshi-approver is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arbrown @shakeebshams @NimJay