Add support for AutokeyConfig and KeyHandle KMS resources #10665

tdbhacks · 2024-05-11T00:21:39Z

Add support for the new AutokeyConfig and KeyHandle KMS resources, used to auto-provision KMS keys ready for Customer Managed Encryption Key (CMEK) use.

Release Note Template for Downstream PRs (will be copied)

`google_kms_autokey_config`

`google_kms_key_handle`

modular-magician · 2024-05-11T05:02:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1279 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1409 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-11T05:06:59Z

Tests analytics

Total tests: 35
Passed tests: 29
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

kms

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample|TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician · 2024-05-11T05:07:27Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Error message] [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-05-12T17:57:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1279 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1409 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-12T18:02:18Z

Tests analytics

Total tests: 35
Passed tests: 29
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

kms

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample|TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician · 2024-05-12T18:02:47Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Error message] [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-05-12T18:50:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1279 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1409 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-12T18:54:45Z

Tests analytics

Total tests: 35
Passed tests: 29
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

kms

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample|TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician · 2024-05-12T18:55:14Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Error message] [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-05-12T20:00:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1277 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1405 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-12T20:05:46Z

Tests analytics

Total tests: 35
Passed tests: 29
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

kms

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample|TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician · 2024-05-12T20:06:16Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Error message] [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-05-12T20:34:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1277 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1409 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-12T20:38:37Z

Tests analytics

Total tests: 35
Passed tests: 29
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

kms

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample|TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician · 2024-05-12T20:39:05Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Error message] [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-05-12T20:53:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1276 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1407 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-12T20:58:05Z

Tests analytics

Total tests: 35
Passed tests: 29
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

kms

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample|TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician · 2024-05-12T21:00:01Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Error message] [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-05-12T22:31:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1282 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1419 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-12T22:36:20Z

Tests analytics

Total tests: 35
Passed tests: 29
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

kms

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample|TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician · 2024-05-12T22:38:27Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Error message] [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-05-12T23:01:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1282 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1419 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-12T23:06:21Z

Tests analytics

Total tests: 35
Passed tests: 29
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

kms

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample|TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician · 2024-05-12T23:08:27Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Error message] [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-05-12T23:30:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1282 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1419 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-12T23:35:10Z

Tests analytics

Total tests: 35
Passed tests: 29
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

kms

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample|TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician · 2024-05-12T23:39:58Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccKMSKeyHandle_kmsKeyHandleBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-05-13T04:35:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1296 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1433 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-13T04:40:58Z

Tests analytics

Total tests: 35
Passed tests: 30
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages

kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample

Get to know how VCR tests work

modular-magician · 2024-05-13T04:41:09Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-05-13T05:12:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1300 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1437 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-13T05:18:08Z

Tests analytics

Total tests: 35
Passed tests: 30
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages

kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample

Get to know how VCR tests work

modular-magician · 2024-05-13T05:18:58Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-05-13T05:46:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1298 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1541 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-13T05:51:40Z

Tests analytics

Total tests: 35
Passed tests: 30
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages

kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample

Get to know how VCR tests work

modular-magician · 2024-05-13T05:54:05Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-05-13T06:16:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1272 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 9 files changed, 1517 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 148 insertions(+))

modular-magician · 2024-05-13T06:21:37Z

Tests analytics

Total tests: 35
Passed tests: 30
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages

kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample

Get to know how VCR tests work

modular-magician · 2024-05-13T06:26:01Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

tdbhacks · 2024-05-13T14:16:16Z

I'll open a new PR now that this is all debugged and tests are passing!

tdbhacks added 5 commits May 10, 2024 19:44

Add AutokeyConfig Cloud KMS resource.

b733b75

Add KeyHandle Cloud KMS resource.

7266f82

Drop handwritten acceptance tests in favor of autogenerated

6f47f07

leftover cleanup in keyhandle example test

dd3a82b

add test_env_vars to yaml example

15ee183

modular-magician added the service/cloudkms label May 11, 2024

shorten project names

9c7291b

tdbhacks force-pushed the autopilot branch from 2242719 to 9c7291b Compare May 12, 2024 18:38

tdbhacks force-pushed the autopilot branch from fce9d61 to 7829835 Compare May 12, 2024 20:23

drop google-beta from time resources

92d238d

tdbhacks force-pushed the autopilot branch from 7829835 to 92d238d Compare May 12, 2024 20:42

tdbhacks force-pushed the autopilot branch from d7ec77e to 252b91f Compare May 12, 2024 22:50

add wait for service agent

17e7927

tdbhacks force-pushed the autopilot branch from 252b91f to 17e7927 Compare May 12, 2024 23:19

add wait before autokeyconfig is set

5ef23e5

tdbhacks force-pushed the autopilot branch from 0467bb1 to 5ef23e5 Compare May 13, 2024 05:00

reuse initial part of keyhandle test

607c2fd

skip destroy in tests

198e97f

tdbhacks closed this May 13, 2024

Add support for AutokeyConfig and KeyHandle KMS resources #10665

Add support for AutokeyConfig and KeyHandle KMS resources #10665

Conversation

tdbhacks commented May 11, 2024 • edited

modular-magician commented May 11, 2024

Diff report

modular-magician commented May 11, 2024

Tests analytics

Action taken

modular-magician commented May 11, 2024

modular-magician commented May 12, 2024

Diff report

modular-magician commented May 12, 2024

Tests analytics

Action taken

modular-magician commented May 12, 2024

modular-magician commented May 12, 2024

Diff report

modular-magician commented May 12, 2024

Tests analytics

Action taken

modular-magician commented May 12, 2024

modular-magician commented May 12, 2024

Diff report

modular-magician commented May 12, 2024

Tests analytics

Action taken

modular-magician commented May 12, 2024

modular-magician commented May 12, 2024

Diff report

modular-magician commented May 12, 2024

Tests analytics

Action taken

modular-magician commented May 12, 2024

modular-magician commented May 12, 2024

Diff report

modular-magician commented May 12, 2024

Tests analytics

Action taken

modular-magician commented May 12, 2024

modular-magician commented May 12, 2024

Diff report

modular-magician commented May 12, 2024

Tests analytics

Action taken

modular-magician commented May 12, 2024

modular-magician commented May 12, 2024

Diff report

modular-magician commented May 12, 2024

Tests analytics

Action taken

modular-magician commented May 12, 2024

modular-magician commented May 12, 2024

Diff report

modular-magician commented May 12, 2024

Tests analytics

Action taken

modular-magician commented May 12, 2024

modular-magician commented May 13, 2024

Diff report

modular-magician commented May 13, 2024

Tests analytics

Action taken

modular-magician commented May 13, 2024

modular-magician commented May 13, 2024

Diff report

modular-magician commented May 13, 2024

Tests analytics

Action taken

modular-magician commented May 13, 2024

modular-magician commented May 13, 2024

Diff report

modular-magician commented May 13, 2024

Tests analytics

Action taken

modular-magician commented May 13, 2024

modular-magician commented May 13, 2024

Diff report

modular-magician commented May 13, 2024

Tests analytics

tdbhacks commented May 11, 2024 •

edited