Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local_ssd_interface to Dataproc Cluster's disk_config. #10663

Merged
merged 1 commit into from May 14, 2024

Conversation

Harwayne
Copy link
Contributor

Adds local_ssd_interface to Dataproc Cluster's disk_config.

Fixes hashicorp/terraform-provider-google#15927

Release Note Template for Downstream PRs (will be copied)

dataproc: added `local_ssd_interface` to `google_dataproc_cluster` resource

@github-actions github-actions bot requested a review from BBBmau May 10, 2024 22:51
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 10, 2024
@modular-magician modular-magician added service/dataproc and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 13, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 109 insertions(+), 63 deletions(-))
google-beta provider: Diff ( 3 files changed, 109 insertions(+), 63 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_cluster (51 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_cluster" "primary" {
  cluster_config {
    master_config {
      disk_config {
        num_local_ssds = # value needed
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 57
Passed tests: 50
Skipped tests: 5
Affected tests: 2

Click here to see the affected service packages
  • dataproc

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocCluster_spotWithAuxiliaryNodeGroups|TestAccDataprocCluster_withConfigOverrides

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocCluster_spotWithAuxiliaryNodeGroups[Debug log]
TestAccDataprocCluster_withConfigOverrides[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@BBBmau
Copy link
Collaborator

BBBmau commented May 13, 2024

not sure why its marking disk_config as missing, I've checked the Test file and it's clearly there. I'll approve and merge this since the tests are passing.

@Harwayne
Copy link
Contributor Author

Is there anything else I should do before this merges?

@BBBmau
Copy link
Collaborator

BBBmau commented May 14, 2024

ah sorry, we needed to fix some VCR tests which is why it wasn't merged right away!

@BBBmau BBBmau merged commit 87e753c into GoogleCloudPlatform:main May 14, 2024
11 checks passed
@Harwayne Harwayne deleted the b-303808477 branch May 14, 2024 21:13
kautikdk pushed a commit to kautikdk/magic-modules that referenced this pull request May 16, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
ma-g-22 pushed a commit to ma-g-22/magic-modules that referenced this pull request May 21, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants