Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort parameters in oics link and remove white spaces in generated Go files #10662

Merged
merged 3 commits into from May 13, 2024

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented May 10, 2024

  1. Sort the parameters alphabetically in oics link
  2. Modify templates to remove white spaces in generated files
  3. Remove autogen notice and hashicorp copyright from handwritten files

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 267 files changed, 649 insertions(+), 749 deletions(-))
google-beta provider: Diff ( 267 files changed, 649 insertions(+), 749 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 74
Passed tests: 71
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • migrationcenter
  • monitoring
  • netapp
$\textcolor{green}{\textsf{All tests passed!}}$ View the [build log](https://storage.cloud.google.com/ci-vcr-logs/beta/refs/heads/auto-pr-10662/artifacts/427201e8-d172-4895-a866-c130734efd52/build-log/replaying_test.log)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 267 files changed, 649 insertions(+), 749 deletions(-))
google-beta provider: Diff ( 267 files changed, 649 insertions(+), 749 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 74
Passed tests: 71
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • migrationcenter
  • monitoring
  • netapp
$\textcolor{green}{\textsf{All tests passed!}}$ View the [build log](https://storage.cloud.google.com/ci-vcr-logs/beta/refs/heads/auto-pr-10662/artifacts/14f90222-2156-4682-9d56-b28ea2810e8f/build-log/replaying_test.log)

@zli82016 zli82016 requested a review from c2thorn May 13, 2024 16:24
@zli82016 zli82016 changed the title Sort parameters in oics link Sort parameters in oics link and remove white spaces in generated Go files May 13, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 267 files changed, 649 insertions(+), 749 deletions(-))
google-beta provider: Diff ( 267 files changed, 649 insertions(+), 749 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 74
Passed tests: 71
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • migrationcenter
  • monitoring
  • netapp
$\textcolor{green}{\textsf{All tests passed!}}$ View the [build log](https://storage.cloud.google.com/ci-vcr-logs/beta/refs/heads/auto-pr-10662/artifacts/4d5fab9d-b94e-4fd7-ab8d-0d69aa665f13/build-log/replaying_test.log)

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy fix! thanks

@zli82016 zli82016 merged commit cdbface into GoogleCloudPlatform:main May 13, 2024
11 checks passed
@zli82016 zli82016 deleted the order-oics-links branch May 13, 2024 18:28
kautikdk pushed a commit to kautikdk/magic-modules that referenced this pull request May 16, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
ma-g-22 pushed a commit to ma-g-22/magic-modules that referenced this pull request May 21, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants