Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote google_cloud_asset_resources_search_all datasource to ga #10660

Merged
merged 7 commits into from May 14, 2024

Conversation

averbuks
Copy link
Member

@averbuks averbuks commented May 10, 2024

Promote google_cloud_asset_resources_search_all datasource to ga
hashicorp/terraform-provider-google#18034

Note: CloudAsset V1 API: resourcesSearchAll has multiple dynamicType fields, which is currently impossible to handle well in the provider. All suth fields and some useless are avoided in the datasource, including additional_attributes field. We still keep additional_attributes field in the beta datasource, since beta API has a fixed type for the field.

Release Note Template for Downstream PRs (will be copied)

`google_cloud_asset_resources_search_all`

@github-actions github-actions bot requested a review from rileykarson May 10, 2024 21:22
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 264 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 2 files changed, 5 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 4
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • cloudasset

Non-exercised tests

Tests were added that are GA-only additions and require manual runs:

  • TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic$\textcolor{green}{\textsf{All tests passed!}}$
    View the build log

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any guarantee that, other than additional_attributes, the GA API here is a superset of the beta one? We may want to add a separate resource if there aren't, data.google_cloud_asset_search_all_resources.

The tests for a datasource are definitely not complete enough to assert as much.

@github-actions github-actions bot requested a review from rileykarson May 14, 2024 11:54
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 414 insertions(+))
google-beta provider: Diff ( 6 files changed, 415 insertions(+), 15 deletions(-))

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 414 insertions(+))
google-beta provider: Diff ( 6 files changed, 415 insertions(+), 15 deletions(-))

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
all service packages are affected

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccDataSourceGoogleCloudAssetSearchAllResources_basic

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
all service packages are affected

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccDataSourceGoogleCloudAssetSearchAllResources_basic

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 414 insertions(+))
google-beta provider: Diff ( 6 files changed, 417 insertions(+), 17 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3653
Passed tests: 3280
Skipped tests: 371
Affected tests: 2

Click here to see the affected service packages
all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccCloudFunctionsFunction_firestore|TestAccDataSourceGoogleCloudAssetSearchAllResources_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudFunctionsFunction_firestore[Error message] [Debug log]
TestAccDataSourceGoogleCloudAssetSearchAllResources_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 414 insertions(+))
google-beta provider: Diff ( 6 files changed, 417 insertions(+), 17 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3653
Passed tests: 3280
Skipped tests: 371
Affected tests: 2

Click here to see the affected service packages
all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccCloudFunctionsFunction_firestore|TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, waiting on test results.

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudFunctionsFunction_firestore[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants