Go push jobs #10659
Go push jobs #10659
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
.ci/magician/cmd/sync_branch.go
Outdated
| rnr, err := exec.NewRunner() | ||
| if err != nil { | ||
| fmt.Println("Error creating Runner: ", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
This should return an error instead of exiting
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
2 similar comments
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
This PR is approved and has been waiting for merge for 7 days. Is it ready to merge? Use the label |
.ci/gcb-push-downstream.yml
Outdated
| @@ -88,18 +88,15 @@ steps: | |||
| - 'ga' | |||
| - $COMMIT_SHA | |||
|
|
|||
| - name: 'gcr.io/cloud-builders/git' | |||
| - name: 'gcr.io/graphite-docker-images/build-environment' | |||
There was a problem hiding this comment.
Do these need the build-environment image? I think `go-plus might be sufficient?
There was a problem hiding this comment.
go-plus should be fine here.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
This PR has been waiting for review for 2 days. Please take a look! Use the label |
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label |
Merge after #10658
Release Note Template for Downstream PRs (will be copied)