-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for google_compute_ssl_certificate
to TGC
#10653
Add support for google_compute_ssl_certificate
to TGC
#10653
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failing:
│ Error: Invalid function argument
│
│ on example_google_compute_ssl_certificate.tf line 17, in resource "google_compute_ssl_certificate" "webserver_cert":
│ 17: certificate = file("/etc/apache2/ssl/apache.crt")
Could you please add the files on the test directory? Or I think we could try adding those on the repository and update the path. What do you think? |
In the providers we have a test directory that we can add this sort of files to: https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/third_party/terraform/services/compute/test-fixtures I'm not sure how this works for TGC, @rileykarson do you know? |
@slevenick I have just updated the files with a new version that should work now without need to upload the certificates once it create those one. |
@slevenick could you please review again? |
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 7 days. Please take a look! Use the label |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
adding support for compute.googleapis.com/SslCertificate