Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for google_compute_ssl_certificate to TGC #10653

Merged

Conversation

delimaneto
Copy link
Contributor

adding support for compute.googleapis.com/SslCertificate

@github-actions github-actions bot requested a review from slevenick May 10, 2024 14:24
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 10, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 42 insertions(+))

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failing:
│ Error: Invalid function argument

│ on example_google_compute_ssl_certificate.tf line 17, in resource "google_compute_ssl_certificate" "webserver_cert":
│ 17: certificate = file("/etc/apache2/ssl/apache.crt")

@delimaneto
Copy link
Contributor Author

files.zip

Could you please add the files on the test directory? Or I think we could try adding those on the repository and update the path. What do you think?

@slevenick
Copy link
Contributor

In the providers we have a test directory that we can add this sort of files to: https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/third_party/terraform/services/compute/test-fixtures

I'm not sure how this works for TGC, @rileykarson do you know?

@github-actions github-actions bot requested a review from slevenick May 10, 2024 15:18
@franciscolimaneto
Copy link

@slevenick I have just updated the files with a new version that should work now without need to upload the certificates once it create those one.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 10, 2024
@delimaneto
Copy link
Contributor Author

@slevenick could you please review again?

Copy link

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 7 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 17, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 44 insertions(+))

@slevenick slevenick merged commit dc73581 into GoogleCloudPlatform:main May 17, 2024
11 checks passed
avijain25 pushed a commit to avijain25/magic-modules that referenced this pull request May 21, 2024
ma-g-22 pushed a commit to ma-g-22/magic-modules that referenced this pull request May 21, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants