Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run unit tests in tools and rename magician unit tests #10651

Merged
merged 8 commits into from May 20, 2024
Merged

Run unit tests in tools and rename magician unit tests #10651

merged 8 commits into from May 20, 2024

Conversation

shuyama1
Copy link
Member

@shuyama1 shuyama1 commented May 10, 2024 •
edited

fixes hashicorp/terraform-provider-google#17598

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1 shuyama1 requested a review from melinath May 13, 2024 17:16
@shuyama1
Copy link
Member Author

I assume changing GHA workflow file name will not interrupt ongoing PRs. Please correct me if my assumption is wrong

melinath
melinath requested changes May 13, 2024
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be easy to also add test steps for the template-check tool?

.github/workflows/unit-test-tools.yml Outdated
@@ -1,12 +1,12 @@
name: unit-tests-diff-processor
name: unit-tests-tools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests -> test for consistency

Suggested change
name: unit-tests-tools
name: unit-test-tools

.github/workflows/unit-test-tools.yml Outdated
- 'tools/diff-processor/**'
- '.github/workflows/unit-tests-diff-processor.yml'
- 'tools/**'
- '.github/workflows/unit-tests-tools.yml'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- '.github/workflows/unit-tests-tools.yml'
- '.github/workflows/unit-test-tools.yml'

.github/workflows/unit-test-tools.yml Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

2 similar comments
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1 shuyama1 requested a review from melinath May 16, 2024 04:59
melinath
melinath approved these changes May 16, 2024
View reviewed changes
.ci/magician/cmd/check_cassettes.go Outdated
@@ -42,7 +42,7 @@ var checkCassettesCmd = &cobra.Command{
The following environment variables are expected:
` + listCCEnvironmentVariables() + `

It prints a list of tests that failed in replaying mode along with all test output.`,
It prints a list of tests that failed in replaying mode along with all test output. Add this line to trigger unit tests`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to revert

.github/workflows/unit-test-tools.yml Outdated
- '.github/workflows/unit-test-tools.yml'

jobs:
unit-test-diff-processor:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the unit-test part of these job names is redundant because of how these are displayed in the UI:

Screenshot 2024-05-16 at 9 52 36 AM
Suggested change
unit-test-diff-processor:
diff-processor:

tools/diff-processor/cmd/breaking_changes.go Outdated
@@ -13,7 +13,7 @@ import (
"github.com/spf13/cobra"
)

const breakingChangesDesc = `Check for breaking changes between the new / old Terraform provider versions.`
const breakingChangesDesc = `Check for breaking changes between the new / old Terraform provider versions. Add this line to trigger unit tests`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to revert

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1 shuyama1 merged commit 85b7cf6 into GoogleCloudPlatform:main May 20, 2024
14 checks passed
@shuyama1 shuyama1 deleted the fix_run_tools_unit_tests branch May 20, 2024 18:40
@modular-magician modular-magician mentioned this pull request May 20, 2024
Merged
avijain25 pushed a commit to avijain25/magic-modules that referenced this pull request May 21, 2024
@shuyama1 @avijain25
Run unit tests in tools and rename magician unit tests (GoogleCloudPl…
7fc2f5b 
…atform#10651)
ma-g-22 pushed a commit to ma-g-22/magic-modules that referenced this pull request May 21, 2024
@shuyama1 @ma-g-22
Run unit tests in tools and rename magician unit tests (GoogleCloudPl…
e28e7d9 
…atform#10651)
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
@shuyama1 @pengq-google
Run unit tests in tools and rename magician unit tests (GoogleCloudPl…
ef939e1 
…atform#10651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@shuyama1 @modular-magician @melinath