Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added functionality in mmv1 to support configurable sweepers #10650

Merged
merged 6 commits into from May 13, 2024

Conversation

shuyama1
Copy link
Member

@shuyama1 shuyama1 commented May 9, 2024

fixes hashicorp/terraform-provider-google#16859

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 18 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 29
Passed tests: 28
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • datacatalog
$\textcolor{green}{\textsf{All tests passed!}}$ View the [build log](https://storage.cloud.google.com/ci-vcr-logs/beta/refs/heads/auto-pr-10650/artifacts/21194a47-31ef-4aff-920e-508f92dd59a4/build-log/replaying_test.log)

@shuyama1 shuyama1 requested a review from c2thorn May 13, 2024 17:04
Co-authored-by: Cameron Thornton <camthornton@google.com>
class Sweeper < Google::YamlValidator
# The field checked by sweeper to determine
# eligibility for deletion for generated resources
attr_reader :tf_test_field
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little confused at what this was at first... can you think of a better name for this? I can't think of anything perfect, but maybe sweepable_name_field or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I was also struggled to find a better name for it. I'll update it with a more clear name, sweepable_name_field seems a good one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change it to sweepable_identifier_field. let me know if that makes sense

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot clearer thanks!

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just have an opinion on attribute name

@c2thorn
Copy link
Member

c2thorn commented May 13, 2024

As far as Go rewrite, we haven't gotten to sweepers yet, so this should be good to add right now.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 18 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 29
Passed tests: 28
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • datacatalog

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 18 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 29
Passed tests: 28
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • datacatalog

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@shuyama1 shuyama1 requested a review from c2thorn May 13, 2024 20:43
@shuyama1 shuyama1 merged commit 398f07b into GoogleCloudPlatform:main May 13, 2024
15 checks passed
@shuyama1 shuyama1 deleted the fixit_sweeper branch May 13, 2024 22:17
kautikdk pushed a commit to kautikdk/magic-modules that referenced this pull request May 16, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
ma-g-22 pushed a commit to ma-g-22/magic-modules that referenced this pull request May 21, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants