Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run unit tests for tools in a PR check #17598

Closed
roaks3 opened this issue Mar 15, 2024 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#10651 or GoogleCloudPlatform/terraform-google-conversion#2281
Closed

Run unit tests for tools in a PR check #17598

roaks3 opened this issue Mar 15, 2024 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#10651 or GoogleCloudPlatform/terraform-google-conversion#2281
Assignees
@shuyama1
Labels
magician Issues and features related to our bespoke CI magician-pr-ux size/s technical-debt
Milestone
Near-Term Goals

Comments

@roaks3
Copy link
Collaborator

roaks3 commented Mar 15, 2024

What kind of contribution is this issue about?

Pull request UX

Details

Raised in GoogleCloudPlatform/magic-modules#10199 (comment)

The tools in magic-modules like our issue-labeler include unit tests, but it appears that we don't run them in PR checks.

When adding these tests to a PR check, we might want to make sure they only run when tools are modified (I'm not sure if they would cause noise otherwise, or if they could be impacted by other changes).

References

No response
@roaks3 roaks3 mentioned this issue Mar 15, 2024
Merged
@rileykarson rileykarson added this to the Goals milestone Mar 18, 2024
@rileykarson rileykarson added the magician Issues and features related to our bespoke CI label Mar 28, 2024
@melinath melinath modified the milestones: Goals, Near-Term Goals Apr 30, 2024
@melinath melinath self-assigned this Apr 30, 2024
@melinath
Copy link
Collaborator

Note from grooming: Can we just test everything in the tools directory?

@melinath melinath assigned shuyama1 and unassigned melinath May 6, 2024
@shuyama1 shuyama1 mentioned this issue May 10, 2024
Merged
@modular-magician modular-magician mentioned this issue May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shuyama1 shuyama1

Labels
magician Issues and features related to our bespoke CI magician-pr-ux size/s technical-debt
Projects
None yet
Milestone
Near-Term Goals
4 participants
@melinath @rileykarson @roaks3 @shuyama1