Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update set custom timeout sample #3831

Closed

Conversation

olavloite
Copy link
Contributor

Updates the 'Set custom timeout and retry settings' sample to one that uses the possibility of setting a specific timeout for one method call. This does however not support setting retry settings.

Fixes #3805

Use the newly added feature that allows a client to set a custom
timeout for a method call, instead of using the static option when
creating a client.

Fixes GoogleCloudPlatform#3805
@olavloite olavloite added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: spanner Issues related to the Spanner API. labels Sep 25, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2020
@product-auto-label product-auto-label bot added api: docs Issues related to the Docs API API. samples Issues that are directly related to samples. and removed api: spanner Issues related to the Spanner API. labels Sep 26, 2020
@lesv
Copy link
Contributor

lesv commented Oct 22, 2020

@skuruppu Should we abandon this PR?

@skuruppu
Copy link
Contributor

It seems that way. @olavloite if you can confirm and close this PR, that would be great.

@olavloite
Copy link
Contributor Author

Yep, agreed.

@olavloite olavloite closed this Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: docs Issues related to the Docs API API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: update the code sample to set timeout at method level
3 participants