New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add QueryOptions samples for JDBC #2347
feat: add QueryOptions samples for JDBC #2347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is only one or two things that need any action on.
Overall I like this. Let me know what we might need to do the get testing to pass. It will probably be easier if we use EnvVar's instead of java properties. And we really don't want customers to consider using -SNAPSHOT's.
spanner/jdbc/pom.xml
Outdated
<dependency> | ||
<groupId>com.google.cloud</groupId> | ||
<artifactId>google-cloud-spanner-jdbc</artifactId> | ||
<version>1.13.1-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use -SNAPSHOT's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change that as soon as a version of the JDBC driver with support for QueryOptions
has been released. Until then this PR won't build anyways, so it can't be merged by accident either.
spanner/jdbc/src/test/java/com/example/spanner/JdbcSampleIT.java
Outdated
Show resolved
Hide resolved
@lesv |
884c3fb
to
ad9b4ac
Compare
@olavloite if you could look at the tests that would be great. Looks like there are some failures. |
…a-docs-samples into spanner-jdbc-query-options
All the required dependencies have now been merged, so it should now be possible to get the test cases up and running. For that the integration test needs access to a Spanner instance and database. I assumed that the Java system properties |
Great - other than it doesn't compile. |
It depends on |
You can hard code these in your test. If you need me to do something in java-docs-samples-testing, let me know. We have default-instance in us-central1 and the following DB's:
|
Adds samples for
QueryOptions
for Cloud Spanner JDBC. This PR also adds basic infrastructure for samples for Cloud Spanner JDBC.The PR currently fails to build as the changes that are needed have not yet been added to the JDBC driver.