Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): do not emit nil error formatting #3562

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grayside
Copy link
Contributor

@grayside grayside commented Nov 9, 2023

Description

When using the cloudrunci retry mechanism, if multiple retries are made and the test fails without an error being reported, a nil error comes out. This was a distraction.

request: no acceptable response after 5 retries: %!w(<nil>))

This PR removes the nil error from output.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@grayside grayside self-assigned this Nov 9, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant