Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add turbo replication (RPO) samples #2279

Merged
merged 13 commits into from Jan 27, 2022

Conversation

BrennaEpp
Copy link
Contributor

@BrennaEpp BrennaEpp commented Oct 21, 2021

Fixes #2252

Requires googleapis/google-cloud-go#5003

Added some functionality to wait for a bucket to be propagated for tests

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2021
@snippet-bot
Copy link

snippet-bot bot commented Oct 21, 2021

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Oct 21, 2021
@BrennaEpp BrennaEpp added the status: blocked Resolving the issue is dependent on other work. label Oct 26, 2021
@BrennaEpp BrennaEpp marked this pull request as ready for review October 26, 2021 22:57
@BrennaEpp BrennaEpp requested review from a team as code owners October 26, 2021 22:57
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 29, 2021
Copy link

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but I defer to the Go experts.

@BrennaEpp BrennaEpp requested a review from a team January 26, 2022 01:14
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor things, sorry I didn't review this earlier! Feel free to merge once fixed.

storage/buckets/create_bucket_turbo_replication.go Outdated Show resolved Hide resolved
storage/buckets/set_rpo_async_turbo.go Outdated Show resolved Hide resolved
storage/buckets/buckets_test.go Outdated Show resolved Hide resolved
storage/buckets/buckets_test.go Outdated Show resolved Hide resolved
@BrennaEpp BrennaEpp removed the status: blocked Resolving the issue is dependent on other work. label Jan 26, 2022
@BrennaEpp BrennaEpp enabled auto-merge (squash) January 27, 2022 02:03
@BrennaEpp BrennaEpp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2022
@BrennaEpp BrennaEpp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2022
@BrennaEpp BrennaEpp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2022
@BrennaEpp BrennaEpp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2022
auto-merge was automatically disabled January 27, 2022 20:30

Pull Request is not mergeable

@BrennaEpp BrennaEpp enabled auto-merge (squash) January 27, 2022 21:30
@BrennaEpp BrennaEpp merged commit 13789c3 into GoogleCloudPlatform:main Jan 27, 2022
@BrennaEpp BrennaEpp deleted the rpo branch January 27, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: Add samples for turbo replication
5 participants