Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add PublicAccessPrevention samples #1919

Merged
merged 6 commits into from Jun 30, 2021

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Jan 26, 2021

Adds samples for 3 new region tags for PublicAccessPrevention
feature. See library PR at googleapis/google-cloud-go#3608

Adds samples for 3 new region tags for PublicAccessPrevention
feature. See library PR at googleapis/google-cloud-go#3608
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 26, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jan 26, 2021

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 26, 2021
Copy link
Contributor

@shaffeeullah shaffeeullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! One minor suggestion

storage/buckets/get_public_access_prevention.go Outdated Show resolved Hide resolved
storage/buckets/buckets_test.go Outdated Show resolved Hide resolved
storage/buckets/get_public_access_prevention.go Outdated Show resolved Hide resolved
@tritone tritone added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 28, 2021
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will wait to approve until ready to submit.

storage/buckets/buckets_test.go Outdated Show resolved Hide resolved
@tritone tritone requested review from codyoss and tbpg January 28, 2021 16:42
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaffeeullah
Copy link
Contributor

@tritone ,

We would like to merge these samples next week after the client library has been released. Does that work for you?

@shaffeeullah
Copy link
Contributor

Public access prevention rollout has been delayed due to a bug surfaced during Googler preview. I will keep this PR updated as I learn new release timeline details.

@tritone tritone requested a review from a team as a code owner June 29, 2021 22:36
@tritone tritone added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 29, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 30, 2021
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Jun 30, 2021
@codyoss codyoss merged commit f1b9124 into GoogleCloudPlatform:master Jun 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants