Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing/sampletests): make its own module #1711

Merged
merged 3 commits into from Sep 15, 2020
Merged

chore(testing/sampletests): make its own module #1711

merged 3 commits into from Sep 15, 2020

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Sep 15, 2020

With the most recent commit, x/tools/packages will require 1.12.
Carve out a new module with proper go version.

With the most recent commit, x/tools/packages will require 1.12.
Carve out a new module with proper go version.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2020
@codyoss
Copy link
Member Author

codyoss commented Sep 15, 2020

Related to googleapis/google-cloud-go#2849

Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check the installation of sampletests just in case we need to cd into that directory first (so we are inside the right module).

testing/sampletests/go.mod Show resolved Hide resolved
@codyoss
Copy link
Member Author

codyoss commented Sep 15, 2020

Please double-check the installation of sampletests just in case we need to cd into that directory first (so we are inside the right module).

You're right, fixed.

@tbpg tbpg added the automerge Merge the pull request once unit tests and other checks pass. label Sep 15, 2020
@codyoss codyoss merged commit 474f150 into GoogleCloudPlatform:master Sep 15, 2020
@codyoss codyoss deleted the sampletest2 branch September 15, 2020 19:31
grayside pushed a commit that referenced this pull request Sep 22, 2020
With the most recent commit, x/tools/packages will require 1.12.
Carve out a new module with proper go version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants