Allow to define custom handlers for uncaught exceptions. #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`process.on('uncaughtException')` and `process.on('unhandledRejectoin')`
handlers are suitable to do some final cleanup & send errors somewhere.
However, Functions Framework does non-graceful `process.exit()` so any
user-defined cleanup does not have a chance to finish.
So I propose to expose the `ERROR_HANDLER` to the user:
```javascript
const framework = require('@google-cloud/functions-framework');
const origCallback = framework.ERROR_HANDLER.onUncaughtExceptionCallback;
framework.ERROR_HANDLER.onUncaughtExceptionCallback = (err) => {
flush(timeout).then(() => origCallback(err));
};
```
marshall-lee
force-pushed
the
custom-uncaught-exception-handler
branch
from
9b0faac
to
a3c002c
Compare
|
Thanks for the PR. I commented on the GitHub issue #215 (comment) with a suggested design and a prototype. |
|
Closing in favor of the linked GitHub issue which needs an approved design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.on('uncaughtException')andprocess.on('unhandledRejectoin')handlers are suitable to do some final cleanup & send errors somewhere.
However, Functions Framework does non-graceful
process.exit()so anyuser-defined cleanup does not have a chance to finish.
So I propose to expose the
ERROR_HANDLERto the user: