Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Modified parameters for BigtableToParquet" #1546

Closed
wants to merge 1 commit into from

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented May 10, 2024

Reverts #1490

Bad merge reverted recent commits

@Abacn Abacn requested a review from a team as a code owner May 10, 2024 16:36
@Abacn Abacn requested review from manitgupta and shreyakhajanchi and removed request for a team May 10, 2024 16:36
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 57.20430% with 199 lines in your changes are missing coverage. Please review.

Project coverage is 40.24%. Comparing base (9bf17b5) to head (e00a800).
Report is 25 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1546      +/-   ##
============================================
- Coverage     40.26%   40.24%   -0.03%     
+ Complexity     2816     2811       -5     
============================================
  Files           740      740              
  Lines         42899    42899              
  Branches       4604     4604              
============================================
- Hits          17275    17266       -9     
- Misses        24133    24139       +6     
- Partials       1491     1494       +3     
Components Coverage Δ
spanner-templates 56.77% <0.00%> (-0.06%) ⬇️
spanner-import-export 65.46% <0.00%> (-0.14%) ⬇️
spanner-live-forward-migration 63.17% <0.00%> (ø)
spanner-live-reverse-replication 42.95% <0.00%> (ø)
spanner-bulk-migration 69.97% <0.00%> (ø)
Files Coverage Δ
.../it/gcp/bigquery/BigQueryResourceManagerUtils.java 83.33% <100.00%> (ø)
...gcp/datastream/DatastreamResourceManagerUtils.java 100.00% <100.00%> (ø)
...gcp/spanner/utils/SpannerResourceManagerUtils.java 97.50% <100.00%> (ø)
...oud/teleport/plugin/PythonDockerfileGenerator.java 85.71% <ø> (ø)
...gle/cloud/teleport/bigtable/BigtableToParquet.java 41.86% <ø> (ø)
...leport/templates/SpannerVectorEmbeddingExport.java 0.00% <ø> (ø)
...d/teleport/templates/common/DatadogConverters.java 81.25% <ø> (ø)
...teleport/templates/common/DatastoreConverters.java 62.67% <ø> (ø)
...rt/templates/common/JavascriptTextTransformer.java 66.22% <ø> (ø)
...ud/teleport/templates/common/PubsubConverters.java 0.00% <ø> (ø)
... and 33 more

... and 3 files with indirect coverage changes

@Abacn
Copy link
Contributor Author

Abacn commented May 13, 2024

superceded by #1547

@Abacn Abacn closed this May 13, 2024
@Abacn Abacn deleted the revert-1490-koppas-dataflowTemplates branch May 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant