Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert sharded migration ITs to use Avro #1543

Merged
merged 4 commits into from May 20, 2024

Conversation

manitgupta
Copy link
Member

No description provided.

@manitgupta manitgupta requested a review from a team as a code owner May 10, 2024 10:37
@manitgupta manitgupta requested review from Deep1998 and krishnamoorthy-r and removed request for a team May 10, 2024 10:37
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.94%. Comparing base (bcf01b8) to head (f5299e5).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1543      +/-   ##
============================================
+ Coverage     40.93%   40.94%   +0.01%     
- Complexity     2812     2815       +3     
============================================
  Files           740      740              
  Lines         42832    42832              
  Branches       4581     4581              
============================================
+ Hits          17532    17537       +5     
+ Misses        23799    23795       -4     
+ Partials       1501     1500       -1     
Components Coverage Δ
spanner-templates 59.81% <ø> (+0.01%) ⬆️
spanner-import-export 65.61% <ø> (+0.04%) ⬆️
spanner-live-forward-migration 73.58% <ø> (ø)
spanner-live-reverse-replication 48.51% <ø> (ø)
spanner-bulk-migration 77.69% <ø> (ø)

see 3 files with indirect coverage changes

@manitgupta
Copy link
Member Author

manitgupta commented May 10, 2024 via email

Copy link
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darshan-sj darshan-sj added the Google LGTM Approval of a pull request to be merged into the repository label May 17, 2024
@copybara-service copybara-service bot merged commit 821784e into GoogleCloudPlatform:main May 20, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Google LGTM Approval of a pull request to be merged into the repository size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants