New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert sharded migration ITs to use Avro #1543
Merged
copybara-service
merged 4 commits into
GoogleCloudPlatform:main
from
manitgupta:manit-fixit-4
May 20, 2024
Merged
Convert sharded migration ITs to use Avro #1543
copybara-service
merged 4 commits into
GoogleCloudPlatform:main
from
manitgupta:manit-fixit-4
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manitgupta
requested review from
Deep1998 and
krishnamoorthy-r
and removed request for
a team
May 10, 2024 10:37
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1543 +/- ##
============================================
+ Coverage 40.93% 40.94% +0.01%
- Complexity 2812 2815 +3
============================================
Files 740 740
Lines 42832 42832
Branches 4581 4581
============================================
+ Hits 17532 17537 +5
+ Misses 23799 23795 -4
+ Partials 1501 1500 -1
|
darshan-sj
requested changes
May 10, 2024
...d/teleport/v2/templates/DataStreamToSpannerShardedMigrationWithMigrationShardIdColumnIT.java
Outdated
Show resolved
Hide resolved
You're right! I will fix this and other tests where I've made the same
mistake!
Thank you so much!
…On Fri, May 10, 2024, 17:58 darshan-sj ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
v2/datastream-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/DataStreamToSpannerShardedMigrationWithMigrationShardIdColumnIT.java
<#1543 (comment)>
:
> @@ -270,80 +282,80 @@ private void assertUsersTableContents() {
row.put("migration_shard_id", "L1");
events.add(row);
- row = new HashMap<>();
- row.put("id", 2);
- row.put("name", "Tester2");
- row.put("age_spanner", 33);
+ row.clear();
My guess is the assert structs method iterates over these row objects one
by one and checks if it is present in the structs returned from spanner.
So, it is checking if the last row hashmap object exists in struct n times.
—
Reply to this email directly, view it on GitHub
<#1543 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSOX5WYZ6COYOE22W6PUSDZBS4NFAVCNFSM6AAAAABHQMYQ5OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBZHE3TGNJYHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
darshan-sj
approved these changes
May 13, 2024
...eleport/v2/templates/DataStreamToSpannerShardedMigrationWithoutMigrationShardIdColumnIT.java
Show resolved
Hide resolved
…mnIT to use Avro instead of JSON
…T to use Avro instead of JSON
darshan-sj
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
darshan-sj
added
the
Google LGTM
Approval of a pull request to be merged into the repository
label
May 17, 2024
copybara-service
bot
merged commit May 20, 2024
821784e
into
GoogleCloudPlatform:main
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.