Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groupName attribute to v2 template where it's needed (part 2) #1541

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akashorabek
Copy link
Contributor

No description provided.

@akashorabek akashorabek marked this pull request as ready for review May 10, 2024 05:20
@akashorabek akashorabek requested a review from a team as a code owner May 10, 2024 05:20
@akashorabek akashorabek requested review from asthamohta and VardhanThigle and removed request for a team May 10, 2024 05:20
@Amar3tto
Copy link
Contributor

Currently in process of fixing, in accordance with the comments from #1542

@Amar3tto
Copy link
Contributor

PR is ready for review

@liferoad liferoad requested a review from an2x May 23, 2024 13:09
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.92%. Comparing base (bcf01b8) to head (c7da0a7).
Report is 118 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1541      +/-   ##
============================================
- Coverage     40.93%   40.92%   -0.01%     
- Complexity     2813     2814       +1     
============================================
  Files           740      740              
  Lines         42832    42875      +43     
  Branches       4581     4585       +4     
============================================
+ Hits          17533    17548      +15     
- Misses        23798    23824      +26     
- Partials       1501     1503       +2     
Components Coverage Δ
spanner-templates 59.80% <ø> (ø)
spanner-import-export 65.59% <ø> (ø)
spanner-live-forward-migration 73.58% <ø> (ø)
spanner-live-reverse-replication 48.51% <ø> (ø)
spanner-bulk-migration 77.69% <ø> (ø)
Files Coverage Δ
...leport/v2/auto/blocks/PubsubMessageToTableRow.java 0.00% <ø> (ø)
.../cloud/teleport/v2/auto/blocks/ReadFromPubSub.java 0.00% <ø> (ø)
...cloud/teleport/v2/auto/blocks/WriteToBigQuery.java 0.00% <ø> (ø)
...e/cloud/teleport/v2/auto/blocks/WriteToPubSub.java 0.00% <ø> (ø)
...cloud/teleport/v2/auto/dlq/WriteDlqToBigQuery.java 0.00% <ø> (ø)
.../cloud/teleport/v2/templates/PubSubToBigQuery.java 34.67% <ø> (ø)
...ogle/cloud/teleport/v2/templates/PubsubToAvro.java 11.62% <ø> (ø)
.../cloud/teleport/v2/templates/TextIOToBigQuery.java 68.00% <ø> (ø)
...leport/v2/templates/pubsubtotext/PubsubToText.java 0.00% <ø> (ø)
...v2/transforms/WriteDataChangeRecordsToGcsAvro.java 90.32% <ø> (ø)
... and 7 more

... and 10 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants