Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groupName attribute to v2 template where it's needed (part 1) #1539

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akashorabek
Copy link
Contributor

No description provided.

@akashorabek akashorabek marked this pull request as ready for review May 10, 2024 05:20
@akashorabek akashorabek requested a review from a team as a code owner May 10, 2024 05:20
@akashorabek akashorabek requested review from Deep1998 and shreyakhajanchi and removed request for a team May 10, 2024 05:20
@Amar3tto
Copy link
Contributor

PR is ready for review

@liferoad liferoad requested a review from an2x May 23, 2024 13:08
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.89%. Comparing base (aecc881) to head (51d2c92).
Report is 200 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1539      +/-   ##
============================================
+ Coverage     40.42%   40.89%   +0.46%     
- Complexity     2782     2801      +19     
============================================
  Files           750      738      -12     
  Lines         42568    42796     +228     
  Branches       4555     4577      +22     
============================================
+ Hits          17207    17500     +293     
+ Misses        23880    23790      -90     
- Partials       1481     1506      +25     
Components Coverage Δ
spanner-templates 59.65% <46.02%> (+0.71%) ⬆️
spanner-import-export 65.30% <ø> (-0.29%) ⬇️
spanner-live-forward-migration 73.58% <91.07%> (+4.47%) ⬆️
spanner-live-reverse-replication 48.42% <89.13%> (+0.40%) ⬆️
spanner-bulk-migration 77.69% <44.17%> (-2.48%) ⬇️
Files Coverage Δ
...d/teleport/v2/templates/AzureEventhubToPubsub.java 7.89% <ø> (ø)
...cloud/teleport/v2/templates/BigQueryToParquet.java 1.63% <ø> (ø)
...ort/v2/templates/BigtableChangeStreamsToHBase.java 0.00% <ø> (ø)
...dc/applier/CdcToBigQueryChangeApplierPipeline.java 0.00% <ø> (ø)
...e/cloud/teleport/v2/transforms/WriteToGCSAvro.java 18.75% <ø> (ø)
...loud/teleport/v2/transforms/WriteToGCSParquet.java 13.04% <ø> (ø)
...e/cloud/teleport/v2/transforms/WriteToGCSText.java 17.14% <ø> (ø)
...ort/v2/templates/DataplexFileFormatConversion.java 75.75% <ø> (ø)
...ud/teleport/v2/templates/DataStreamToBigQuery.java 0.00% <ø> (ø)
...ud/teleport/v2/templates/DataStreamToPostgres.java 0.00% <ø> (ø)
... and 9 more

... and 46 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants