Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added unit tests to Spanner transaction writer #1538

Merged
merged 4 commits into from May 15, 2024
Merged

added unit tests to Spanner transaction writer #1538

merged 4 commits into from May 15, 2024

Conversation

shreyakhajanchi
Copy link
Contributor

No description provided.

@shreyakhajanchi shreyakhajanchi requested a review from a team as a code owner May 9, 2024 16:53
@shreyakhajanchi shreyakhajanchi requested review from manitgupta and krishnamoorthy-r and removed request for a team May 9, 2024 16:53
@shreyakhajanchi shreyakhajanchi marked this pull request as draft May 9, 2024 16:54
@codecov Codecov
Copy link

codecov bot commented May 10, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.45%. Comparing base (c3b0a42) to head (5667766).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1538      +/-   ##
============================================
+ Coverage     40.25%   40.45%   +0.19%     
- Complexity     2814     2831      +17     
============================================
  Files           740      740              
  Lines         42899    42905       +6     
  Branches       4604     4604              
============================================
+ Hits          17269    17356      +87     
+ Misses        24138    24053      -85     
- Partials       1492     1496       +4
Components Coverage Δ
spanner-templates 57.57% <92.30%> (+0.77%) ⬆️
spanner-import-export 65.61% <ø> (+0.08%) ⬆️
spanner-live-forward-migration 65.80% <92.30%> (+2.63%) ⬆️
spanner-live-reverse-replication 42.95% <80.00%> (ø)
spanner-bulk-migration 69.97% <80.00%> (ø)
Files Coverage Δ
...ort/v2/templates/SpannerTransactionWriterDoFn.java 66.35% <100.00%> (+66.35%) ⬆️

... and 8 files with indirect coverage changes

@shreyakhajanchi shreyakhajanchi marked this pull request as ready for review May 10, 2024 10:11
darshan-sj
darshan-sj approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@darshan-sj darshan-sj added the Google LGTM Approval of a pull request to be merged into the repository label May 10, 2024
@copybara-service copybara-service bot merged commit 47114de into GoogleCloudPlatform:main May 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darshan-sj darshan-sj darshan-sj approved these changes

@manitgupta manitgupta Awaiting requested review from manitgupta manitgupta is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

@krishnamoorthy-r krishnamoorthy-r Awaiting requested review from krishnamoorthy-r krishnamoorthy-r is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

Assignees
No one assigned
Labels
Google LGTM Approval of a pull request to be merged into the repository size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shreyakhajanchi @darshan-sj