Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KAFKA_TOPIC template parameters. #1537

Merged
merged 2 commits into from May 17, 2024

Conversation

an2x
Copy link
Member

@an2x an2x commented May 9, 2024

This updates the templates Maven plugin / template metadata generation utils to support KAFKA_TOPIC parameter type.

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 39.99%. Comparing base (98eeb81) to head (5c92cc8).
Report is 175 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1537      +/-   ##
============================================
- Coverage     40.06%   39.99%   -0.08%     
+ Complexity     2815     2806       -9     
============================================
  Files           761      753       -8     
  Lines         42916    42714     -202     
  Branches       4603     4582      -21     
============================================
- Hits          17195    17082     -113     
+ Misses        24231    24153      -78     
+ Partials       1490     1479      -11     
Components Coverage Δ
spanner-templates 56.73% <ø> (+0.34%) ⬆️
spanner-import-export 65.61% <ø> (+0.06%) ⬆️
spanner-live-forward-migration 61.23% <ø> (-0.33%) ⬇️
spanner-live-reverse-replication 42.53% <ø> (-0.40%) ⬇️
spanner-bulk-migration 72.00% <ø> (+2.13%) ⬆️
Files Coverage Δ
...gle/cloud/teleport/metadata/TemplateParameter.java 0.00% <ø> (ø)
...le/cloud/teleport/metadata/util/MetadataUtils.java 39.70% <ø> (+1.47%) ⬆️
.../teleport/plugin/model/ImageSpecParameterType.java 100.00% <100.00%> (ø)
...loud/teleport/plugin/model/ImageSpecParameter.java 30.45% <85.71%> (+2.31%) ⬆️

... and 39 files with indirect coverage changes

@Dippatel98 Dippatel98 added the Google LGTM Approval of a pull request to be merged into the repository label May 9, 2024
Co-authored-by: Anand Inguva <34158215+AnandInguva@users.noreply.github.com>
@Dippatel98 Dippatel98 added Google LGTM Approval of a pull request to be merged into the repository and removed Google LGTM Approval of a pull request to be merged into the repository labels May 17, 2024
@copybara-service copybara-service bot merged commit dbff166 into GoogleCloudPlatform:main May 17, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Google LGTM Approval of a pull request to be merged into the repository size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants