Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch EventsIT and SessionIT from JSON to Avro #1535

Merged
merged 2 commits into from May 14, 2024
Merged

Switch EventsIT and SessionIT from JSON to Avro #1535

merged 2 commits into from May 14, 2024

Conversation

manitgupta
Copy link
Member

Switches DatastreamToSpannerEventsIT and DatastreamToSpannerSessionIT to use avro records instead of JSON.

@manitgupta manitgupta requested a review from a team as a code owner May 9, 2024 10:39
@manitgupta manitgupta requested review from asthamohta and VardhanThigle and removed request for a team May 9, 2024 10:39
@manitgupta manitgupta requested a review from darshan-sj May 9, 2024 10:40
@codecov Codecov
Copy link

codecov bot commented May 9, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.18%. Comparing base (5597215) to head (6e7b262).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1535   +/-   ##
=========================================
  Coverage     40.18%   40.18%           
- Complexity     2791     2793    +2     
=========================================
  Files           737      737           
  Lines         42768    42768           
  Branches       4578     4578           
=========================================
+ Hits          17186    17187    +1     
- Misses        24100    24101    +1     
+ Partials       1482     1480    -2
Components Coverage Δ
spanner-templates 56.82% <ø> (+0.03%) ⬆️
spanner-import-export 65.59% <ø> (+0.08%) ⬆️
spanner-live-forward-migration 63.17% <ø> (ø)
spanner-live-reverse-replication 42.95% <ø> (ø)
spanner-bulk-migration 69.97% <ø> (ø)

see 3 files with indirect coverage changes

darshan-sj
darshan-sj approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darshan-sj darshan-sj added the Google LGTM Approval of a pull request to be merged into the repository label May 10, 2024
@copybara-service copybara-service bot merged commit 60ad396 into GoogleCloudPlatform:main May 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darshan-sj darshan-sj darshan-sj approved these changes

@asthamohta asthamohta Awaiting requested review from asthamohta asthamohta is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

@VardhanThigle VardhanThigle Awaiting requested review from VardhanThigle VardhanThigle is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

Assignees
No one assigned
Labels
Google LGTM Approval of a pull request to be merged into the repository size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manitgupta @darshan-sj