New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BULK MISC FIXES: Add error counters; Fix null string handlings #1533
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1533 +/- ##
============================================
+ Coverage 40.18% 40.27% +0.08%
- Complexity 2791 2813 +22
============================================
Files 737 741 +4
Lines 42768 42914 +146
Branches 4578 4603 +25
============================================
+ Hits 17186 17282 +96
- Misses 24100 24140 +40
- Partials 1482 1492 +10
|
v2/sourcedb-to-spanner/src/main/java/com/google/cloud/teleport/v2/constants/MetricCounters.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...-spanner/src/main/java/com/google/cloud/teleport/v2/transformer/SourceRowToMutationDoFn.java
Outdated
Show resolved
Hide resolved
...in/java/com/google/cloud/teleport/v2/spanner/migrations/avro/GenericRecordTypeConvertor.java
Outdated
Show resolved
Hide resolved
e0ffc44
to
a97250a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
24409db
into
GoogleCloudPlatform:main
Add error counters for reader and transformer.
Fix null string handlings