Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BULK MISC FIXES: Add error counters; Fix null string handlings #1533

Merged
merged 2 commits into from May 14, 2024

Conversation

Deep1998
Copy link
Contributor

@Deep1998 Deep1998 commented May 8, 2024

Add error counters for reader and transformer.
Fix null string handlings

@Deep1998 Deep1998 requested a review from a team as a code owner May 8, 2024 10:17
@Deep1998 Deep1998 requested review from aksharauke and krishnamoorthy-r and removed request for a team May 8, 2024 10:17
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 40.27%. Comparing base (5597215) to head (a97250a).

❗ Current head a97250a differs from pull request most recent head 3030f70. Consider uploading reports for the commit 3030f70 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1533      +/-   ##
============================================
+ Coverage     40.18%   40.27%   +0.08%     
- Complexity     2791     2813      +22     
============================================
  Files           737      741       +4     
  Lines         42768    42914     +146     
  Branches       4578     4603      +25     
============================================
+ Hits          17186    17282      +96     
- Misses        24100    24140      +40     
- Partials       1482     1492      +10     
Components Coverage Δ
spanner-templates 56.84% <93.10%> (+0.05%) ⬆️
spanner-import-export 65.52% <ø> (+0.02%) ⬆️
spanner-live-forward-migration 63.14% <92.85%> (-0.03%) ⬇️
spanner-live-reverse-replication 42.94% <92.85%> (-0.02%) ⬇️
spanner-bulk-migration 70.05% <93.10%> (+0.08%) ⬆️
Files Coverage Δ
...jdbc/dialectadapter/mysql/MysqlDialectAdapter.java 100.00% <100.00%> (ø)
.../reader/io/jdbc/rowmapper/JdbcSourceRowMapper.java 100.00% <100.00%> (ø)
...leport/v2/transformer/SourceRowToMutationDoFn.java 100.00% <100.00%> (ø)
...er/migrations/avro/GenericRecordTypeConvertor.java 95.20% <100.00%> (-0.12%) ⬇️
...le/cloud/teleport/v2/constants/MetricCounters.java 0.00% <0.00%> (ø)
.../v2/spanner/migrations/avro/AvroToValueMapper.java 92.46% <88.88%> (-0.50%) ⬇️

... and 38 files with indirect coverage changes

@Deep1998 Deep1998 added the Google LGTM Approval of a pull request to be merged into the repository label May 8, 2024
Copy link
Contributor

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pull-request-size pull-request-size bot added size/L and removed size/M labels May 10, 2024
@Deep1998 Deep1998 changed the title Add error counters for transformer and reader BULK MISC FIXES: Add error counters; Fix null string handlings May 10, 2024
@Deep1998 Deep1998 force-pushed the count branch 2 times, most recently from e0ffc44 to a97250a Compare May 10, 2024 12:38
Copy link
Contributor

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@copybara-service copybara-service bot merged commit 24409db into GoogleCloudPlatform:main May 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Google LGTM Approval of a pull request to be merged into the repository size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants